Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when targeting 7.0 in 17.3 and remove 7.0 from the list of supported targets #28224

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Add warning when targeting 7.0 in 17.3 and remove 7.0 from the list of supported targets #28224

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
415a006
Add warning when targeting 7.0 in 17.3 and remove 7.0 from the list o…
marcpopMSFT Sep 28, 2022
a26437e
Fix up tests that include the new target net7 on 17.3 warning to only…
marcpopMSFT Sep 29, 2022
8d23cce
Fix message to trigger on earlier than 17.4 rather than 17.3.
marcpopMSFT Oct 4, 2022
045b56d
VisualStudioVersion is actually 17.0 in the VS command prompt even in…
marcpopMSFT Oct 4, 2022
2fcce3d
Revert the test changes that are no longer needed because of the prio…
marcpopMSFT Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,4 +871,8 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1191: A runtime identifier for the property '{0}' couldn't be inferred. Specify a rid explicitly.</value>
<comment>{StrBegin="NETSDK1191: "}</comment>
</data>
<data name="Net7NotCompatibleWithDev173" xml:space="preserve">
<value>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</value>
<comment>{StrBegin="NETSDK1192: "}</comment>
</data>
</root>
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: Cílení na .NET 6.0 nebo vyšší ve Visual Studio 2019 se nepodporuje.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: Pro zadaný identifikátor RuntimeIdentifier {0} není k dispozici žádný hostitel aplikace.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: .NET 6.0 oder höher wird als Ziel in Visual Studio 2019 nicht unterstützt.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: Für den angegebenen RuntimeIdentifier "{0}" ist kein Anwendungshost verfügbar.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: No se admite el destino de .NET 6.0 o superior en Visual Studio 2019.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: No hay ningún host de aplicación disponible para el valor de RuntimeIdentifier especificado "{0}".</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: le ciblage de .NET 6.0 ou plus dans Visual Studio 2019 n’est pas pris en charge.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: il n'existe aucun d'hôte d'application disponible pour le RuntimeIdentifier spécifié '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: la destinazione .NET 6.0 o versione successiva in Visual Studio 2019 non è supportata.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: non è disponibile alcun host applicazione per l'elemento RuntimeIdentifier specificato '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: Visual Studio 2019 では .NET 6.0 以降をターゲットにすることはできません。</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: 指定された RuntimeIdentifier '{0}' で利用できるアプリケーション ホストはありません。</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: Visual Studio 2019에서 .NET 6.0 이상을 대상으로 하는 것은 지원되지 않습니다.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: 지정된 RuntimeIdentifier '{0}'에 사용할 수 있는 애플리케이션 호스트가 없습니다.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: Platforma docelowa .NET 6.0 lub nowsza w usłudze Visual Studio 2019 nie jest obsługiwana.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: Brak dostępnej aplikacji hosta dla określonego elementu RuntimeIdentifier „{0}”.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: o direcionamento do .NET 6.0 ou superior no Visual Studio 2019 não é compatível.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: não há nenhum host do aplicativo disponível para o RuntimeIdentifier especificado '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: выбор .NET 6.0 или более поздней версии в качестве цели в Visual Studio 2019 не поддерживается.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: нет узла приложения для указанного RuntimeIdentifier "{0}".</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: Visual Studio 2019'da .NET 6.0 veya daha üst sürümünü hedefleme desteklenmiyor.</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: Belirtilen RuntimeIdentifier '{0}' için kullanılabilecek bir uygulama konağı yok.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: 不支持在 Visual Studio 2019 中以 .NET 6.0 或更高版本为目标。</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: 没有应用程序主机可用于指定的 RuntimeIdentifier“{0}”。</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1182: 不支援在 Visual Studio 2019 中以 .NET 6.0 或更高版本為目標。</target>
<note>{StrBegin="NETSDK1182: "}</note>
</trans-unit>
<trans-unit id="Net7NotCompatibleWithDev173">
<source>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</source>
<target state="new">NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</target>
<note>{StrBegin="NETSDK1192: "}</note>
</trans-unit>
<trans-unit id="NoAppHostAvailable">
<source>NETSDK1084: There is no application host available for the specified RuntimeIdentifier '{0}'.</source>
<target state="translated">NETSDK1084: 對指定的 RuntimeIdentifier '{0}'，無法使用任何應用程式主機。</target>
Expand Down
6 changes: 6 additions & 0 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,12 @@ Copyright (c) .NET Foundation. All rights reserved.
<NetSdkWarning ResourceName="Net6NotCompatibleWithDev16"/>
</Target>

<Target Name="_WarnWhenUsingNET7AndVSPriorTo173"
BeforeTargets="_CheckForInvalidConfigurationAndPlatform"
Condition="$([MSBuild]::VersionLessThan($(VisualStudioVersion), '17.3')) and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '7.0'))">
<NetSdkWarning ResourceName="Net7NotCompatibleWithDev173"/>
</Target>

<Target Name="_CheckForInvalidWindowsDesktopTargetingConfiguration"
BeforeTargets="_CheckForInvalidConfigurationAndPlatform"
Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '5.0')) and ('$(UseWindowsForms)' == 'true' or '$(UseWPF)' == 'true')">
Expand Down
3 changes: 2 additions & 1 deletion src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetFrameworks.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ Copyright (c) .NET Foundation. All rights reserved.
<SupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v3.1" DisplayName=".NET Core 3.1" Alias="netcoreapp3.1" />
<SupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v5.0" DisplayName=".NET 5.0" Alias="net5.0" />
<SupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v6.0" DisplayName=".NET 6.0" Alias="net6.0" />
<SupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v7.0" DisplayName=".NET 7.0" Alias="net7.0" />
<SupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v7.0" DisplayName=".NET 7.0" Alias="net7.0"
Condition="$([MSBuild]::VersionGreaterThanOrEquals($(MSBuildVersion), '17.4'))"/>
</ItemGroup>

<!-- .NET Standard -->
Expand Down