Add warning when targeting 7.0 in 17.3 and remove 7.0 from the list of supported targets #28224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f supported targets.
dsplaisted
approved these changes
Sep 28, 2022
… run on 17.4 and up
… 17.4. Switching to check msbuild version as that works here though not sure what we do in the future if we truly need vs version.
|
@dsplaisted it turns out VisualStudioVersion is set to 17.0 even in 17.4. We can't rely on that property. I switched to using MSBuild instead as that seems to work but pinging you to raise visibility here for this. |
Makes sense. |
…r bad VSVersion logic. Update the logic to consistently use the three part version (even though it doesn't matter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Targeting 7.0 will not work in 17.3 because of source generators that will light up when targeting net7.0. We're not sure the exact error experience. This PR will provide a warning message to customers and make that option not show up in the property pages either.
Customer Impact
New warning when targeting 7.0 and using 17.3 MSBuild. Customers won't be able to swtich to use net7.0 from the VS properties.
Regression
No
Risk
Low. This is already not supported
Testing
manual/automated