Remove -r parameter for dotnet test, and change -a parameter to be shorthand for --arch, instead of --test-adapter-path #22497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
reviewed
Nov 8, 2021
| command.AddOption(NoRestoreOption); | ||
| command.AddOption(CommonOptions.InteractiveMsBuildForwardOption); | ||
| command.AddOption(CommonOptions.VerbosityOption); | ||
| command.AddOption(CommonOptions.LongFormArchitectureOption); |
There was a problem hiding this comment.
Because we'll support --arch/-a for architecture and no more -a for test adapter or have I misunderstood?
sdk/src/Cli/dotnet/CommonOptions.cs
Line 122 in a5dae2a
The long form contains only --arch
sdk/src/Cli/dotnet/CommonOptions.cs
Line 128 in a5dae2a
|
/azp run |
|
Commenter does not have sufficient privileges for PR 22497 in repo dotnet/sdk |
nohwnd
changed the title
dotnet test for 7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21952
Closes #21389
cc: @nohwnd