Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] For dotnet test, switch -a to alias --arch instead of --test-adapter-path #21389

Closed
richlander opened this issue Sep 24, 2021 · 2 comments · Fixed by #22497
Closed
Labels
Area-DotNet Test untriaged Request triage from a team member

Comments

@richlander
Copy link
Member

richlander commented Sep 24, 2021

Check it out ...

rich@MacBook-Air-M1-2020 tests % dotnet test --help | grep -- -a
  -a, --test-adapter-path <ADAPTER_PATH>  The path to the custom adapters to 
  --blame-crash-collect-always            Enables collecting crash dump on 
  <blame-crash-collect-always>            expected as well as unexpected 
  --arch <arch>                           The target architecture.
rich@MacBook-Air-M1-2020 tests % dotnet run --help | grep -- -a
  -a, --arch <arch>                    The target architecture.

Sure would be nice to make -a the same everywhere. I doubt that the current usage of -a is common.

This is similar to #21952.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-DotNet Test untriaged Request triage from a team member labels Sep 24, 2021
@sfoslund
Copy link
Member

@nohwnd for the dotnet test team

@nohwnd
Copy link
Member

nohwnd commented Oct 6, 2021

If we are breaking this, that we should probably consider using -r for --runtime, instead of --results-directory. And also check if there are more conflicts with dotnet test.

@richlander richlander changed the title [Breaking change] Consider giving -a to --arch instead of --test-adapter-path [Breaking change] For dotnet test, switch -a to --arch instead of --test-adapter-path Oct 11, 2021
@richlander richlander changed the title [Breaking change] For dotnet test, switch -a to --arch instead of --test-adapter-path [Breaking change] For dotnet test, switch -a to alias --arch instead of --test-adapter-path Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-DotNet Test untriaged Request triage from a team member
Projects
None yet
3 participants