Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/runtime #45042

Merged
merged 32 commits into from
Dec 10, 2024
Merged

[main] Update dependencies from dotnet/runtime #45042

merged 32 commits into from
Dec 10, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 22, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20241210.2
  • Date Produced: December 10, 2024 12:33:42 PM UTC
  • Commit: 920a17ac91440abb5b34109104e72da77ec58b59
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport: from 10.0.0-alpha.1.24569.4 to 10.0.0-alpha.1.24575.2 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 10.0.0-alpha.1.24569.4 to 10.0.0-alpha.1.24575.2 (parent: Microsoft.NETCore.App.Runtime.win-x64)

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
db89f09 
…1122.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24572.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Nov 22, 2024
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@build-analysis build-analysis bot mentioned this pull request Nov 22, 2024
Open
@jeffschwMSFT
Copy link
Member

rerunning leg due to download failure

Download from all targets failed. List of attempted targets: file:///vmr/artifacts/assets/Release/Runtime/10.0.0-alpha.1.24572.1/dotnet-runtime-10.0.0-alpha.1.24572.1-centos.9-x64.tar.gz
 [Check failure on line 565 in /vmr/src/aspnetcore/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj](https://github.com/dotnet/sdk/pull/45042/files#annotation_28951359868)

@jeffschwMSFT
Copy link
Member

@agocke can you take a look? there is a durable download failure

@agocke
Copy link
Member

agocke commented Nov 22, 2024

Looking

@agocke
Copy link
Member

agocke commented Nov 22, 2024

Hmm, this is the VMR so I'm not precisely sure I know what's going on. But I think the "download" here is supposed to be pulling the runtime pack from a local directory -- presumably because the ASP build is assuming that the runtime pack has already been built as part of the VMR. But it doesn't seem like that file is available.

@ViktorHofer Does this problem look familiar to you? Am I right in describing what's going on?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
1abba7d 
…1122.8

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24572.8
@ViktorHofer
Copy link
Member

@carlossanlop can you please take a look at the source-build failures? Those are related to the use of the new maintenance-packages in this repo.

@ViktorHofer
Copy link
Member

@jeffschwMSFT @agocke which failure?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
6ced50b 
…1125.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24575.1
@jeffschwMSFT
Copy link
Member

ha, now it is a different failure.

/vmr/src/roslyn/src/NuGet/Microsoft.CodeAnalysis.Package/Microsoft.CodeAnalysis.Package.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: System.Buffers from 4.6.0 to 4.5.1. Reference the package directly from the project to select a different version. 
 Microsoft.CodeAnalysis -> System.IO.Pipelines 10.0.0-alpha.1.24575.1 -> System.Buffers (>= 4.6.0) 
 Microsoft.CodeAnalysis -> System.Memory 4.5.5 -> System.Buffers (>= 4.5.1)

who is the right person to look at this?

@ViktorHofer
Copy link
Member

cc @carlossanlop @ericstj

@ViktorHofer ViktorHofer mentioned this pull request Nov 25, 2024
Merged
@carlossanlop
Copy link
Member

Microsoft.CodeAnalysis -> System.IO.Pipelines 10.0.0-alpha.1.24575.1 -> System.Buffers (>= 4.6.0)
Microsoft.CodeAnalysis -> System.Memory 4.5.5 -> System.Buffers (>= 4.5.1)

We have the latest versions consumed by buffers, so I suppose we have to make CodeAnalysis consume the latest version as well. I see the error says it's coming from /vmr/src/roslyn/src/NuGet/Microsoft.CodeAnalysis.Package/Microsoft.CodeAnalysis.Package.csproj. Do I need to bump the version here under that folder or in the roslyn repo directly? My hunch says roslyn directly, then flow it here. I'll try that first.

@carlossanlop
Copy link
Member

I just got told to use a patch here. I'll do that first.

@carlossanlop carlossanlop mentioned this pull request Nov 25, 2024
Merged
@carlossanlop
Copy link
Member

Roslyn is also blocked when the dependencies are updated, and can only be unblocked after merging dotnet/msbuild#11038

@ViktorHofer gave me the suggestion of only updating the runtime dependencies when not in source-build. I'll prepare a runtime patch for that.

@carlossanlop carlossanlop requested review from a team as code owners November 26, 2024 01:04
@ViktorHofer
Copy link
Member

The other way around, only in source-build update the packages. And I meant in roslyn, not runtime.

@carlossanlop
Copy link
Member

The other way around, only in source-build update the packages. And I meant in roslyn, not runtime.

But this all started because we updated the deps in runtime, which caused a problem in roslyn, which we tried to fix by updating the deps too, but we can't because we need the msbuild deps to flow first, and that isn't happening any time soon.

What am I missing? How would we fix this in roslyn if roslyn is blocked by msbuild?

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 26, 2024 •
edited
Loading

I tried to explain that in yesterday's stand-up. Source-build uses live dependencies. Roslyn's build is only failing when building from source as the msft build doesn't use the latest runtime packages yet. For a quick workaround, the package version update in roslyn can be conditioned on when building from source.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
0e301f9 
…1126.2

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24576.2
MichaelSimons
MichaelSimons reviewed Nov 26, 2024
View reviewed changes
src/SourceBuild/patches/runtime/0001-PATCH-Only-update-runtime-maintenance-packages-depen.patch Outdated

Roslyn cannot immediately get these same dependencies updated because msbuild will fail to find them.

MSBuild needs to get these package versions updated before all other repos.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the patch guidelines, please add a Backport:<issue/PR> line to track the work that will remove this patch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #45155 to track this.

@carlossanlop carlossanlop mentioned this pull request Nov 26, 2024
Open
@akoeplinger
Copy link
Member

akoeplinger commented Dec 5, 2024 •
edited
Loading

Ah just found #44442 which "fixed" this in 9.0.1xx so this wasn't forward ported to main yet.
And there's this bug report for the sdk: #45262

@akoeplinger akoeplinger mentioned this pull request Dec 5, 2024
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
94373ca 
…1205.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24605.1
@akoeplinger
Copy link
Member

akoeplinger commented Dec 5, 2024 •
edited
Loading

source-build still fails with

/vmr/src/aspnetcore/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj(565,5): error : Download from all targets failed. List of attempted targets: file:///vmr/artifacts/assets/Release/Runtime/10.0.0-alpha.1.24603.18/dotnet-runtime-10.0.0-alpha.1.24603.18-centos.9-x64.tar.gz

The runtime build only produced Runtime/10.0.0-alpha.1.24603.18/dotnet-runtime-internal-10.0.0-alpha.1.24603.18-centos.9-x64.tar.gz, which seems to be the expected name according to https://github.com/dotnet/runtime/blob/e99557baffbe864d624cc1c95c9cbf2eefae684f/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj#L7

@akoeplinger
Copy link
Member

akoeplinger commented Dec 5, 2024 •
edited
Loading

Ok, figured it out: the .tar.gz without the -internal is produced by Microsoft.NETCore.App.Bundle.bundleproj but we excluded that from building in source-build in dotnet/runtime@6a8d484 (#109638)

I think we should switch aspnetcore over to the -internal one since it probably doesn't need the bundle? but -internal is only produced in source-build: https://github.com/dotnet/runtime/blob/e99557baffbe864d624cc1c95c9cbf2eefae684f/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj#L20-L22

@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 5, 2024 •
edited
Loading

@jkoritzinsky PTAL

@jkoritzinsky
Copy link
Member

We should restore the regular zip for the VMR build. I forgot that's produced by the bundleproj. I'll work today on getting the arcade infra correct to build the bundleproj right during source-build.

This was referenced Dec 5, 2024
Merged
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
c9cc399 
…1205.9

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24605.9
@build-analysis build-analysis bot mentioned this pull request Dec 6, 2024
Open
3 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
547dbc9 
…1206.5

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24606.5
@build-analysis build-analysis bot mentioned this pull request Dec 7, 2024
Open
@am11 am11 mentioned this pull request Dec 8, 2024
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
736fce1 
…1209.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24609.1
@ViktorHofer
Copy link
Member

@jkoritzinsky can you please submit your change as a patch meanwhile to unblock this PR?

@ViktorHofer
Copy link
Member

@carlossanlop the razor repo needs the same maintenance-package change for source-build:

/vmr/src/razor/src/Analyzers/Razor.Diagnostics.Analyzers/Razor.Diagnostics.Analyzers.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: System.Threading.Tasks.Extensions from 4.6.0 to centrally defined 4.5.4. Update the centrally managed package version to a higher version.
Razor.Diagnostics.Analyzers -> Microsoft.CodeAnalysis.CSharp 4.13.0-2.24561.1 -> System.Threading.Tasks.Extensions (>= 4.6.0)
Razor.Diagnostics.Analyzers -> System.Threading.Tasks.Extensions (>= 4.5.4)

@carlossanlop carlossanlop mentioned this pull request Dec 9, 2024
Merged
@carlossanlop
[PATCH] Only update razor dependencies coming from
c06365e 
 maintenance-packages when source build is true. Tracking issue:
 #45155
davidwengier added a commit to dotnet/razor that referenced this pull request Dec 10, 2024
@davidwengier
Only update razor dependencies coming from maintenance-packages when …
83ef836 
…source build is true (#11285)

Tracking issue: dotnet/sdk#45155

Unblocks: dotnet/sdk#45042

@ViktorHofer @ericstj @MichaelSimons @akoeplinger
ViktorHofer and others added 2 commits December 10, 2024 09:52
@ViktorHofer
Merge branch 'main' into darc-main-1f7b1145-06b9-49b5-a579-9c430e034d35
8295bb9
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
5b9f248 
…1210.2

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24570.9 -> To Version 10.0.0-alpha.1.24610.2
@ViktorHofer ViktorHofer enabled auto-merge (squash) December 10, 2024 13:57
@ViktorHofer ViktorHofer merged commit c1aad13 into main Dec 10, 2024
41 of 42 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-1f7b1145-06b9-49b5-a579-9c430e034d35 branch December 10, 2024 19:11
akoeplinger added a commit that referenced this pull request Dec 17, 2024
@akoeplinger
Use dotnet exec to run test app in CheckTargetFrameworkDisplayName (#…
981b74b 
…45332)

"dotnet run" does some additional steps like restore and build that we don't need and it can cause issues with additional characters in stdout like in #45042 (comment)

Switch to executing the built .dll directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons left review comments

@carlossanlop carlossanlop carlossanlop left review comments

@nagilson nagilson nagilson approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jeffschwMSFT @agocke @ViktorHofer @carlossanlop @nagilson @NikolaMilosavljevic @akoeplinger @jkoritzinsky @MichaelSimons