Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on updating maintenance-packages dependencies conditioned to only DotNetBuildSourceOnly != true #45155

Open
carlossanlop opened this issue Nov 26, 2024 · 0 comments
Labels
area-runtime Infrastructure untriaged Request triage from a team member

Comments

@carlossanlop
Copy link
Member

This sdk deps flow PR from runtime failed because we shipped new package versions from dotnet/maintenance-packages for System.Buffers, System.Memory, System.Runtime.CompilerServices.Unsafe, System.Numerics.Vectors and System.Threading.Tasks.Extensions.

System.Memory in particular is failing in dotnet/roslyn due to not being able to find System.ReadOnlySpan, which is provided by the package. The underlying root cause is that msbuild is forcing the package version to downgrade. Until we get msbuild to update the package versions, roslyn cannot have those package versions updated.

The sdk deps flow PR is getting at least 2 patches to condition those deps new versions to only happen when not in source build. We will need to take those conditions eventually when the timing is right (maily after msbuild update flows to roslyn).

cc @ViktorHofer @ericstj

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Nov 26, 2024
carlossanlop added a commit to carlossanlop/runtime that referenced this issue Nov 26, 2024
 latest when not in source-build. Tracking issue:
 dotnet/sdk#45155
carlossanlop added a commit to carlossanlop/roslyn that referenced this issue Nov 27, 2024
ViktorHofer pushed a commit to dotnet/roslyn that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-runtime Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

1 participant