Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PortableBuild comparisons #15306

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

jkoritzinsky
Copy link
Member

Compare PortableBuild against false instead of != true as a build is by default portable (and we don't pass PortableBuild=true in a number of scenarios).

Also fix a typo in the source-build step script.

Contributes to unblocking dotnet/sdk#45042

To double check:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • src/Microsoft.DotNet.Build.Tasks.Installers/build/installer.targets: Language not supported
@jkoritzinsky jkoritzinsky enabled auto-merge (squash) December 5, 2024 18:13
@jkoritzinsky jkoritzinsky merged commit fb642e9 into dotnet:main Dec 5, 2024
11 checks passed
@jkoritzinsky jkoritzinsky deleted the baseos-nonportable branch December 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants