Add threadpool starvation endpoints #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to demonstrate threadpool starvation for the tutorial I am adding. dotnet/diagnostics#2907
noahfalk
added a commit
to noahfalk/docs
that referenced
this pull request
Apr 27, 2022
dotnet/diagnostics#2907 This depends on the updated sample code in dotnet/samples#5113
BillWagner
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Thanks for adding these @noahfalk
This LGTM, and I'll merge it now.
One note as you work on the related article: Make sure you include text in the article that repeats the explanations in the comments. Comments in code aren't localized on the docs platform, only the markdown text is translated. Non-English speakers should get all the information they need from the article text.
noahfalk
added a commit
to noahfalk/docs
that referenced
this pull request
Apr 28, 2022
dotnet/diagnostics#2907 This depends on the updated sample code in dotnet/samples#5113
noahfalk
added a commit
to noahfalk/docs
that referenced
this pull request
Apr 28, 2022
dotnet/diagnostics#2907 This depends on the updated sample code in dotnet/samples#5113
noahfalk
added a commit
to dotnet/docs
that referenced
this pull request
Apr 29, 2022
* Adding a threadpool starvation tutorial dotnet/diagnostics#2907 This depends on the updated sample code in dotnet/samples#5113 * Apply suggestions from code review Co-authored-by: David Pine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to demonstrate threadpool starvation for the tutorial I am adding.
dotnet/diagnostics#2907