-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a threadpool starvation tutorial #29182
Conversation
9f8c145
to
687d197
Compare
dotnet/diagnostics#2907 This depends on the updated sample code in dotnet/samples#5113
687d197
to
489c58b
Compare
cc @dotnet/dotnet-diag |
Unrelated: Does |
No, not yet, but let's workshop this idea in the diagnostics repo. I like the idea of having varying ways of presenting stacks quickly at the commandline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few C# suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, it just needs a few suggested changes. Then we can
Co-authored-by: David Pine <[email protected]>
@IEvangelist - thanks for the review! When you could please take another look and see if we've got everything in good shape. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we'll - thank you 🙏
dotnet/diagnostics#2907
This depends on the updated sample code in dotnet/samples#5113
Internal Preview
Debug Threadpool Starvation