Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a threadpool starvation tutorial #29182

Merged
merged 6 commits into from
Apr 29, 2022

Conversation

noahfalk
Copy link
Member

@noahfalk noahfalk commented Apr 27, 2022

dotnet/diagnostics#2907

This depends on the updated sample code in dotnet/samples#5113

Internal Preview

Debug Threadpool Starvation

@noahfalk noahfalk force-pushed the threadpool_starvation branch from 687d197 to 489c58b Compare April 28, 2022 05:53
@noahfalk noahfalk marked this pull request as ready for review April 28, 2022 09:27
@noahfalk noahfalk requested review from tommcdon and a team as code owners April 28, 2022 09:27
@noahfalk
Copy link
Member Author

cc @dotnet/dotnet-diag

@davidfowl
Copy link
Member

Unrelated: Does dotnet stacks report group similar stacks together? That would make it a bit more usable in these cases, sorta like paralell stacks.

@josalem
Copy link
Contributor

josalem commented Apr 28, 2022

Unrelated: Does dotnet stacks report group similar stacks together? That would make it a bit more usable in these cases, sorta like paralell stacks.

No, not yet, but let's workshop this idea in the diagnostics repo. I like the idea of having varying ways of presenting stacks quickly at the commandline.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few C# suggestions

docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions

docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
docs/core/diagnostics/debug-threadpool-starvation.md Outdated Show resolved Hide resolved
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, it just needs a few suggested changes. Then we can :shipit:

@IEvangelist IEvangelist self-assigned this Apr 28, 2022
@noahfalk
Copy link
Member Author

noahfalk commented Apr 29, 2022

@IEvangelist - thanks for the review! When you could please take another look and see if we've got everything in good shape.

@noahfalk noahfalk enabled auto-merge (squash) April 29, 2022 09:12
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants