Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi] Disable failing tests to get CI green #85681

Merged
merged 3 commits into from
May 3, 2023
Merged

[wasi] Disable failing tests to get CI green #85681

merged 3 commits into from
May 3, 2023

Conversation

radical
Copy link
Member

@radical radical commented May 2, 2023 •
edited
Loading

Issues: #82967, #73961, #85690 .

@ghost ghost assigned radical May 2, 2023
@radical radical added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue area-VM-meta-mono os-wasi Related to WASI variant of arch-wasm and removed area-Serialization labels May 2, 2023
@ghost
Copy link

ghost commented May 2, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue: #82967, and #73961

Author: radical
Assignees: radical
Labels:

arch-wasm, disabled-test, area-VM-meta-mono, os-wasi
Milestone: -

@radical
[wasi] Disable failing test
c82e562 
System.Runtime.Serialization.Xml.ReflectionOnly.Tests:DataContractSerializerTests.DCS_MemoryStream_Deserialize_CompatibleWithFullFramework

Issue: dotnet#73961
@radical
[wasi] Disable tests failing depending on tmp fs
bb28858 
System.Runtime.Serialization.Xml.ReflectionOnly.Tests, and System.Runtime.Serialization.Xml.Tests
Test: DataContractSerializerTests.DCS_FileStreamSurrogate

Issue: dotnet#85690
@radical radical changed the title [wasi] Disable failing tests in System.Runtime.Serialization.Xml.Tests [wasi] Disable failing tests to get CI green May 2, 2023
@radical radical marked this pull request as ready for review May 2, 2023 23:50
@radical
Copy link
Member Author

radical commented May 3, 2023

Failures are unrelated.

@radical radical merged commit 43efab5 into dotnet:main May 3, 2023
@radical radical deleted the wasi-ci-green branch May 3, 2023 02:15
This was referenced May 3, 2023
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@maraf maraf Awaiting requested review from maraf

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-VM-meta-mono disabled-test The test is disabled in source code against the issue os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @lewing