Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi] Failing tests in System.Runtime.Serialization.Xml.Tests #82967

Open
radical opened this issue Mar 4, 2023 · 1 comment
Open

[wasi] Failing tests in System.Runtime.Serialization.Xml.Tests #82967

radical opened this issue Mar 4, 2023 · 1 comment
Labels
arch-wasm WebAssembly architecture area-Serialization os-wasi Related to WASI variant of arch-wasm test-failure wasi-tests-wip WIP for enabling wasi tests
Milestone
Future

Comments

@radical
Copy link
Member

radical commented Mar 4, 2023 •
edited
Loading 

  info: Starting:    managed/System.Runtime.Serialization.Xml.Tests.dll
  fail: [FAIL] System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests.TypesTest_Negative(badType: typeof(System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests+TypeWithReadWriteCollectionAndNoCtorOnCollection), exType: typeof(System.Runtime.Serialization.InvalidDataContractException), exMsg: "System.Runtime.Serialization.Xml.XsdDataContractEx"...)
  info: Assert.Throws() Failure
  info: Expected: typeof(System.Runtime.Serialization.InvalidDataContractException)
  info: Actual:   (No exception was thrown)
  info:    at System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests.TypesTest_Negative(Type badType, Type exType, String exMsg)
  info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, IntPtr* args)
  info:    at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

fail: [FAIL] System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterApiTests.Export(testname: "Exp2", export: Action`1 { Method = Void <Export_MemberData>b__7_2(System.Runtime.Serialization.XsdDataContractExporter), Target = <>c { } }, schemaCheck: Action`2 { Method = Void <Export_MemberData>b__3(System.String, System.Xml.Schema.XmlSchemaSet), Target = <>c__DisplayClass7_0 { autoImportKVP = False } })
info: Assert.Equal() Failure
info: Expected: 20
info: Actual:   4
info:    at System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterApiTests.<>c__DisplayClass7_0.<Export_MemberData>b__3(String s, XmlSchemaSet ss)
info:    at System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterApiTests.Export(String testname, Action`1 export, Action`2 schemaCheck)
info:    at System.Object.InvokeStub_ExporterApiTests.Export(Object , Object , IntPtr* )
info:    at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )

fail: [FAIL] DataContractSerializerTests.DCS_MemoryStream_Serialize_UsesBuiltInAdapter
info: XML comparison is also failing
info: Test failed for input: System.IO.MemoryStream
info: Expected: <MemoryStream xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://schemas.datacontract.org/2004/07/System.IO"><__identity i:nil="true" xmlns="http://schemas.datacontract.org/2004/07/System" /><_buffer></_buffer><_capacity>0</_capacity><_expandable>false</_expandable><_exposable>true</_exposable><_isOpen>true</_isOpen><_length>0</_length><_origin>0</_origin><_position>0</_position><_writable>true</_writable></MemoryStream>
info: Actual: <MemoryStream xmlns="http://schemas.datacontract.org/2004/07/System.IO" xmlns:i="http://www.w3.org/2001/XMLSchema-instance"><_buffer/><_capacity>0</_capacity><_expandable>false</_expandable><_exposable>true</_exposable><_isOpen>true</_isOpen><_length>0</_length><_origin>0</_origin><_position>0</_position><_writable>true</_writable></MemoryStream>
info: Expected: True
info: Actual:   False
info:    at System.Runtime.Serialization.Tests.DataContractSerializerHelper.SerializeAndDeserialize[MemoryStream](MemoryStream value, String baseline, DataContractSerializerSettings settings, Func`1 serializerFactory, Boolean skipStringCompare, Boolean verifyBinaryRoundTrip)
info:    at DataContractSerializerTests.<DCS_MemoryStream_Serialize_UsesBuiltInAdapter>g__ValidateObject|238_0(MemoryStream original, String expectedXml, Byte[] expectedData, Int32 expectedPosition, Boolean expectedExposable)
info:    at DataContractSerializerTests.DCS_MemoryStream_Serialize_UsesBuiltInAdapter()
info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object , IntPtr* )
info:    at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )

The two tests above are trimming related, and disabled for browser too - #73961 .
@radical radical added arch-wasm WebAssembly architecture test-failure os-wasi Related to WASI variant of arch-wasm wasi-tests-wip WIP for enabling wasi tests labels Mar 4, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 4, 2023
@ghost
Copy link

ghost commented Mar 4, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details 
  info: Starting:    managed/System.Runtime.Serialization.Xml.Tests.dll
  fail: [FAIL] System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests.TypesTest_Negative(badType: typeof(System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests+TypeWithReadWriteCollectionAndNoCtorOnCollection), exType: typeof(System.Runtime.Serialization.InvalidDataContractException), exMsg: "System.Runtime.Serialization.Xml.XsdDataContractEx"...)
  info: Assert.Throws() Failure
  info: Expected: typeof(System.Runtime.Serialization.InvalidDataContractException)
  info: Actual:   (No exception was thrown)
  info:    at System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests.TypesTest_Negative(Type badType, Type exType, String exMsg)
  info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, IntPtr* args)
  info:    at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
Author: radical
Assignees: -
Labels:

arch-wasm, test-failure, os-wasi, wasi-tests-wip
Milestone: -

radical added a commit to radical/runtime that referenced this issue Mar 4, 2023
@radical
Disable System.Runtime.Serialization.Xml.XsdDataContractExporterTests…
492ac11 
….ExporterTypesTests.TypesTest_Negative - Issue: dotnet#82967
radical added a commit that referenced this issue Mar 8, 2023
@radical
[wasi] Fixes to enable more tests (#82966)
49553e8 
* [wasi] Copy WasmFilesToIncludeInFileSystem to the bundle too

This could be changed in the future to include in the single file bundle

* [wasi] Enable System.IO.Packaging, and System.Data.DataSetExtensions tests

* WasiAppBuilder: Create an empty /tmp

* Disable System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests.TypesTest_Negative - Issue: #82967

* Enable System.Runtime.Serialization.Xml.Tests, and System.Runtime.Serialization.Xml.ReflectionOnly.Tests

Remaining fixed by adding `/tmp`
@radical radical changed the title [wasi] Failing test - System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterTypesTests.TypesTest_Negative [wasi] Failing tests in System.Runtime.Serialization.Xml.Tests May 2, 2023
radical added a commit to radical/runtime that referenced this issue May 2, 2023
@radical
[wasi] Disable failing tests in System.Runtime.Serialization.Xml.Tests
fcefd9d 
Issue: dotnet#82967, and dotnet#73961
@radical radical mentioned this issue May 2, 2023
Merged
radical added a commit that referenced this issue May 3, 2023
@radical
[wasi] Disable failing tests to get CI green (#85681)
43efab5 
* [wasi] Disable failing tests in System.Runtime.Serialization.Xml.Tests

Issue: #82967, and #73961

* [wasi] Disable failing test

System.Runtime.Serialization.Xml.ReflectionOnly.Tests:DataContractSerializerTests.DCS_MemoryStream_Deserialize_CompatibleWithFullFramework

Issue: #73961

* [wasi] Disable tests failing depending on tmp fs

System.Runtime.Serialization.Xml.ReflectionOnly.Tests, and System.Runtime.Serialization.Xml.Tests
Test: DataContractSerializerTests.DCS_FileStreamSurrogate

Issue: #85690
@marek-safar marek-safar added this to the Future milestone Jul 21, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Serialization os-wasi Related to WASI variant of arch-wasm test-failure wasi-tests-wip WIP for enabling wasi tests
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@radical @marek-safar