Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix compression #79547

Merged
merged 6 commits into from
Jan 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 12, 2022

Backport of #79412 to release/7.0

Fixes #77783

/cc @CarnaViire @greenEkatherine

Customer Impact

In .NET 6 we implemented WebSocket compression. It can be configured on per-connection and per-message basis. The per-message configuration is done via WebSocketMessageFlags, which are honored in WebSocket class (used mainly for server-side WebSockets), but are not exposed properly in ClientWebSocket class (used for client-side WebSockets).

The fix unifies behavior of ClientWebSocket with WebSocket. The fix does it by delegating to the encapsulated WebSocket instance (which already works correctly), instead of falling back to parent class implementation.

Regression?

No. The old behavior existed since introducing the feature in .NET 6.

Testing

CI + targeted test case.

Risk

Low risk - the change unifies behavior of ClientWebSocket with WebSocket. It does not add new code or behavior.

Also note that WebSocket compression is disabled by default.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Dec 12, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79412 to release/7.0

/cc @CarnaViire @greenEkatherine

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net, new-api-needs-documentation

Milestone: -

@CarnaViire
Copy link
Member

CarnaViire commented Dec 13, 2022

CI failures are unrelated:

@karelz
Copy link
Member

karelz commented Dec 20, 2022

Known error:

src/libraries/tests.proj(745,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "XcodeBuildApp" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/runner/work/1/s/artifacts/bundles/tests.all/NormalTestAppBundles/System.Runtime.Tests/AppBundle/Release-maccatalyst/System.Runtime.Tests.app'.
   at System.IO.FileSystem.MoveDirectory(String sourceFullPath, String destFullPath, Boolean isCaseSensitiveRename)
   at System.IO.FileSystem.MoveDirectory(String sourceFullPath, String destFullPath)
   at Xcode.BuildAppBundle(String xcodePrjPath, Boolean optimized, String devTeamProvisioning, String destination) in /_/src/tasks/AppleAppBuilder/Xcode.cs:line 533
   at XcodeBuildApp.Execute() in /_/src/tasks/AppleAppBuilder/Xcode.cs:line 108
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

@carlossanlop
Copy link
Member

@CarnaViire @greenEkatherine when this is ready, please add the servicing-consider label and send email to Tactics requesting approval.

@karelz karelz added the Servicing-approved Approved for servicing release label Jan 5, 2023
@karelz
Copy link
Member

karelz commented Jan 5, 2023

Approved by @SteveMCarroll via email on 2023/1/5 7:44am - adding Servicing-approved label.

  • Email: "[Servicing-Consider] [6.0, 7.0] Fix per-message DisableCompression flag ..."

@carlossanlop it is ready for merge.

@carlossanlop
Copy link
Member

Approved by Tactics (7.0.3).
Signed off by area owners.
No OOB changes needed (IsPackable=false in the involved src csproj).
CI failures investigated as unrelated.
Ready to merge. :shipit:

@carlossanlop carlossanlop modified the milestones: 7.0.x, 7.0.3 Jan 5, 2023
@carlossanlop carlossanlop merged commit 9ad3fa0 into release/7.0 Jan 5, 2023
@carlossanlop carlossanlop deleted the backport/pr-79412-to-release/7.0 branch January 5, 2023 19:14
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants