[release/7.0] Workaround MacCatalyst .app output path change in cmake 3.25 #79097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Since AzDO macOS builders where updated to cmake 3.25 we're seeing failures because the .app doesn't end up in the expected output path anymore. Apply a workaround to move it back to the old location. Fixes #78778
|
Tagging subscribers to this area: @directhex Issue DetailsBackport of #79084 to release/7.0 /cc @akoeplinger Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
/cc @carlossanlop |
jeffhandley
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
This looks good to me, and the fix would be valuable to have in the release/7.0 branch since all backports are currently tripping up on this.
(Note @carlossanlop is away from work)
|
Merging to unblock the test runs in this branch (Branding has been done). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #79084 to release/7.0
/cc @akoeplinger
Customer Impact
This fixes a test build break when targetting MacCatalyst on macOS machines that have cmake 3.25 installed.
Testing
CI testing.
Risk
None, this is only used in the dotnet/runtime build.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.