Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Enable System.Data.Common tests #72554

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jul 20, 2022

Fixes #36879

Also removes remnant ActiveIssue #58584

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned mdh1418 Jul 20, 2022
@mdh1418 mdh1418 requested a review from steveisok July 20, 2022 21:33
@mdh1418
Copy link
Member Author

mdh1418 commented Jul 25, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Jul 25, 2022

The failure on runtime is unrelated and was fixed with #72617

@mdh1418
Copy link
Member Author

mdh1418 commented Jul 26, 2022

The tests being re-enabled are indeed passing on iOS/tvOS/MacCatalyst, which were the platforms the issue targets. All other failures are unrelated as this PR only removes ActiveIssues

@mdh1418 mdh1418 merged commit e893232 into dotnet:main Jul 26, 2022
@mdh1418 mdh1418 deleted the enable_system_data_common_ios_tests branch July 27, 2022 13:20
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Data.Common.Tests tests failing on iOS and tvOS
2 participants