Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Libraries][iOS] Microsoft.Extensions.FileProviders.Physical PhysicalFileProviderTests failure #58584

Closed
mdh1418 opened this issue Sep 2, 2021 · 5 comments

Comments

@mdh1418
Copy link
Member

mdh1418 commented Sep 2, 2021

@dotnet-issue-labeler dotnet-issue-labeler bot added area-Extensions-FileSystem untriaged New issue has not been triaged by the area owner labels Sep 2, 2021
@ghost
Copy link

ghost commented Sep 2, 2021

Tagging subscribers to this area: @maryamariyan, @dotnet/area-extensions-filesystem
See info in area-owners.md if you want to be subscribed.

Issue Details

Discovered in unrelated PR for iOSSimulator x64 Release #57208

Microsoft.Extensions.FileProviders.PhysicalFileProviderTests.TokenForEmptyFilter
    Assert.False() Failure\nExpected: False\nActual:   True

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1337772&view=logs&j=accacb66-0a14-52ef-4079-6344686d9d4c&t=34fbd35e-866b-51a1-9063-fb50703b1957
Log: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-57208-merge-9e0e0de14f9742ad80/Microsoft.Extensions.FileProviders.Physical.Tests/1/console.c669c194.log?sv=2019-07-07&se=2021-09-22T16%3A10%3A24Z&sr=c&sp=rl&sig=wEpzOzHKwO8SjGbfSRJ9Ionr6BXHZl%2F%2FcV85ey68eyA%3D

Author: mdh1418
Assignees: -
Labels:

untriaged, area-Extensions-FileSystem

Milestone: -

@mdh1418 mdh1418 changed the title [Libraries][iOS] Microsoft.Extensions.FileProviders PhysicalFileProviderTests failure [Libraries][iOS] Microsoft.Extensions.FileProviders.Physical PhysicalFileProviderTests failure Sep 2, 2021
@danmoseley
Copy link
Member

Let's include full stacks.

        <failure exception-type="Xunit.Sdk.FalseException">
          <message><![CDATA[Assert.False() Failure\nExpected: False\nActual:   True]]></message>
          <stack-trace><![CDATA[   at Microsoft.Extensions.FileProviders.PhysicalFileProviderTests.TokenForEmptyFilter()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>

@mdh1418 is it surprising there's no line number? Is the pdb not getting deployed on iOSSimulator? It makes diagnosis harder.

@danmoseley danmoseley added the os-ios Apple iOS label Sep 2, 2021
@danmoseley
Copy link
Member

                using (var provider = new PhysicalFileProvider(root.RootPath))
                {
                    var token = provider.Watch(string.Empty);

                    Assert.False(token.HasChanged);  // <<<<<
                    Assert.True(token.ActiveChangeCallbacks); 
                }

I think this means that the last write time of the root directory of the DisposableFileSystem changed. But that is unique to this test
RootPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());

Some kind of OS delay ?

@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Sep 3, 2021
@marek-safar marek-safar added this to the 7.0.0 milestone Sep 3, 2021
steveisok pushed a commit that referenced this issue Sep 13, 2021
…t and test fixes for Android (#58841)

Manual backport of #57208, #58519, #58562, #58210, #57732, #58428, #58586, #58745, #57687 to release/6.0

Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally.

This PR looks to reduce the failures on CI by skipping the problematic suites
Skips test suites logged in #53624

ActiveIssues
#58440
#58418
#58367
#58584

Co-authored-by: Mitchell Hwang <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: Jo Shields <[email protected]>
@mdh1418
Copy link
Member Author

mdh1418 commented Sep 24, 2021

Edit: Mistakenly commented on wrong issue!

@mdh1418
Copy link
Member Author

mdh1418 commented Jul 18, 2022

As of commit 349d811, the test passes on iOSSimulator x64 Debug locally.

@mdh1418 mdh1418 closed this as completed Jul 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants