Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebaseline llvm-libunwind tree #72351

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Jul 18, 2022

The purpose of this PR is to extract all the changes we have on top of upstream/original copy: https://github.com/llvm/llvm-project/tree/llvmorg-9.0.0/libunwind in a separate commit. This will make it possible bring llvm-libunwind to the same plan as other external dependencies trees under src/native/external directory in a followup PR.

Please merge it without squashing the commits, otherwise it will defeat its purpose.

I have listed all those commits in description of third commit.

Contributes to #72344

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 18, 2022
@am11 am11 marked this pull request as ready for review July 18, 2022 03:43
@am11 am11 requested a review from MichalStrehovsky as a code owner July 18, 2022 03:43
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
Copy link
Member

jkotas commented Jul 18, 2022

cc @VSadov

@am11 Should this be merged as rebase and merge ?

@am11
Copy link
Member Author

am11 commented Jul 18, 2022

@am11 Should this be merged as rebase and merge ?

Yes please. We just need a reference to the third commit from main branch, for bookkeeping additional modifications in version file. In next PR, I'll move this directory under src\native\external and add the version file.

@VSadov
Copy link
Member

VSadov commented Jul 18, 2022

@am11 - very nice! Thanks!

BTW, #71187 has some libunwind fixes, but I think the llvm-libunwind already has similar fixes, so it may not have any impact here.

@VSadov
Copy link
Member

VSadov commented Jul 18, 2022

rebase and merge is "Not enabled for this branch". I assume someone has the necessary permissions?

@am11 am11 force-pushed the feature/external/llvm-libunwind branch from 4c0ce47 to 6034e73 Compare July 18, 2022 10:05
@am11 am11 force-pushed the feature/external/llvm-libunwind branch from 6034e73 to ce81fcb Compare July 18, 2022 10:06
@jkotas jkotas merged commit 3719058 into dotnet:main Jul 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants