[release/6.0] [mono] Ensure exception_message points to a string #72002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lewing
approved these changes
Jul 12, 2022
rbhanda
added
Servicing-approved
carlossanlop
approved these changes
Aug 11, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #66991 to release/6.0
/cc @lateralusX @stefan-sf-ibm
Customer Impact
Running the podcast app on iOS collecting nettrace file hits unhandled exception and crash the app, #71492. Not seen on other platforms, so most likely an iOS related loader hook triggering an exception not including an exception message.
The issue is possible to work around by disable the exception trace event when collecting nettrace file:
dotnet-trace collect --diagnostic-port ~/my-dev-port,connect --providers Microsoft-Windows-DotNETRuntime:0x00000014C14F4CBD:4,Microsoft-DotNETCore-SampleProfiler:0x0000F00000000000:4 --format speedscopeTesting
Manual, only seen on Xamarin iOS together with podcast app. Fix is simple and has been running in .net7 since April 2022.
Fix has been validated on custom runtime build, #71492 (comment).
Risk
Low.
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.