[mono] Ensure exception_message points to a string #66991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
area-VM-meta-mono
and removed
community-contribution
lambdageek
approved these changes
Mar 22, 2022
lambdageek
approved these changes
Mar 24, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
ghost
locked as resolved and limited conversation to collaborators
|
Looks like this has been hit on iOS (device), #71492. I think we should consider this PR as a backport for .net6. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2655223657 |
|
@lateralusX an error occurred while backporting to release/6.0, please check the run log for details! Error: @lateralusX is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your Microsoft team membership visibility is set to Public on https://github.com/orgs/microsoft/people?query=lateralusX |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2655223657 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
objis an exceptionexception->messagemight beNULLand therefore rendermono_string_chars_internal (exception->message)into aNULLderef. Also ensure thatexception_messageis a valid string in case the else branch is taken.