-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Add console version of browser-bench sample #60733
Merged
radekdoulik
merged 12 commits into
dotnet:main
from
radekdoulik:pr-console-version-of-wasm-bench-sample
Nov 8, 2021
Merged
[wasm] Add console version of browser-bench sample #60733
radekdoulik
merged 12 commits into
dotnet:main
from
radekdoulik:pr-console-version-of-wasm-bench-sample
Nov 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsExample run:
|
Add info about filtering and options to the README
To avoid CSC : error CS8002: Referenced assembly 'Mono.Options, Version=6.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.
radekdoulik
requested review from
pavelsavara,
radical,
vargaz and
lewing
and removed request for
pavelsavara and
radical
November 5, 2021 13:43
vargaz
reviewed
Nov 7, 2021
@@ -7,6 +7,7 @@ | |||
|
|||
<PropertyGroup> | |||
<_SampleProject>Wasm.Console.Sample.csproj</_SampleProject> | |||
<_SampleAssembly> Wasm.Console.Sample.dll</_SampleAssembly> | |||
</PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space after >.
vargaz
approved these changes
Nov 7, 2021
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Dec 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example run: