Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.FileExtensions #57434

Merged
merged 27 commits into from
Jan 11, 2022
Merged

[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.FileExtensions #57434

merged 27 commits into from
Jan 11, 2022

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Aug 15, 2021 •
edited
Loading

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 15, 2021
@ghost
Copy link

ghost commented Aug 15, 2021

Tagging subscribers to this area: @maryamariyan, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605, #54012

Annotated according to:

Author: maxkoshevoi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Configuration, community-contribution
Milestone: -

@maxkoshevoi maxkoshevoi changed the title Enable nullable annotations for Microsoft.Extensions.Configuration.FileExtensions [Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.FileExtensions Aug 15, 2021
@maryamariyan maryamariyan added this to the 7.0.0 milestone Aug 16, 2021
@maxkoshevoi
Update FileConfigurationProvider.cs
df01b01
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-FileExtensions
3083bef
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-FileExtensions
d328d7b
@maxkoshevoi
DisableImplicitAssemblyReferences
9878964
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-FileExtensions
88c4584 
# Conflicts:
#	src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj
#	src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj
#	src/libraries/Microsoft.Extensions.Configuration.FileExtensions/ref/Microsoft.Extensions.Configuration.FileExtensions.csproj
#	src/libraries/Microsoft.Extensions.Configuration.FileExtensions/src/Microsoft.Extensions.Configuration.FileExtensions.csproj
#	src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj
#	src/libraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj
@maxkoshevoi maxkoshevoi marked this pull request as draft October 4, 2021 19:04
@runfoapp runfoapp bot mentioned this pull request Oct 7, 2021
Closed
@maxkoshevoi maxkoshevoi marked this pull request as ready for review October 13, 2021 08:03
@runfoapp runfoapp bot mentioned this pull request Oct 13, 2021
Closed
@maxkoshevoi maxkoshevoi mentioned this pull request Oct 13, 2021
Merged
@eerhardt
Copy link
Member

@maxkoshevoi - Do you think you can make the same changes here as I did in #57433?

  • Merge with main
  • Add the necessary TFMs to the .csprojs

We may need to wait for #57433 to be merged in order to get the changes to MS.Ext.Configuration I made. Or you can make them now, and we can merge any conflicts once the first PR goes in.

@eerhardt
Copy link
Member

@maxkoshevoi - the build is broken. Can you fix it? Look to see how I did it in 99dae39

@maxkoshevoi
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 57434 in repo dotnet/runtime

eerhardt
eerhardt reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one open question is the only comment I have left. After that is resolved, I believe this can be merged.

eerhardt
eerhardt approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change looks good. Thanks for all the work here @maxkoshevoi!

@halter73 - any more thoughts?

@eerhardt eerhardt merged commit ff74f55 into dotnet:main Jan 11, 2022
@maxkoshevoi maxkoshevoi deleted the mk/43605-Configuration-FileExtensions branch January 12, 2022 07:08
@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@halter73 halter73 halter73 approved these changes

Assignees

@eerhardt eerhardt

Labels
area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maxkoshevoi @eerhardt @halter73 @maryamariyan