[Group 3] Enable nullable annotations for Microsoft.Extensions.FileProviders.Physical
#57409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @maryamariyan, @dotnet/area-extensions-filesystem |
maxkoshevoi
changed the title
Microsoft.Extensions.FileProviders.Physical
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PollingFileChangeToken.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Aug 16, 2021
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PollingWildCardChangeToken.cs
Outdated
Show resolved
Hide resolved
2 tasks
Issue to remove/review "!": dotnet#57518
krwq
approved these changes
Aug 25, 2021
dougbu
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Aug 28, 2021
- handle Microsoft.Extensions.FileProviders.Abstractions nullability annotations (dotnet/runtime#57405) - handle Microsoft.Extensions.FileProviders.Physical nullability annotations (dotnet/runtime#57409) - !fixup! improve `HttpConnectionDispatcher.GetConnectionToken(...)` and its use
dotnet-maestro bot
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Aug 29, 2021
[main] Update dependencies from dotnet/efcore dotnet/runtime - Respond to nullable annotations of `StringSegment` - general assumption is we don't create `StringValues` w/ `null` entries - in addition, `StringSegment.IsNullOrEmpty(StringSegment)` doesn't seem to help the compiler - !fixup! - Handle more nullable expressions - mostly about nullability annotations in `StringValues` and `StringSegment` - see dotnet/runtime#58223 for info about the `StringValues` -> `string` implicit conversion - Merge branch 'main' into darc-main-fcbf8a54-42e6-4ded-9535-034b26dfd6ba - Latest nullability updates - handle Microsoft.Extensions.FileProviders.Abstractions nullability annotations (dotnet/runtime#57405) - handle Microsoft.Extensions.FileProviders.Physical nullability annotations (dotnet/runtime#57409) - !fixup! improve `HttpConnectionDispatcher.GetConnectionToken(...)` and its use - Remove some `StringSegment.Value` `null` forgiveness and extra handling - e.g. `ResponseCompressionProvider` used `StringSegment.Value` when a `string` constant would do - also, `MediaTypeHeaderValue.Charset` getter unnecessarily did `StringSegment` -> `string` -> `StringSegment` - also, `CookieHeaderParserShared` ignored `[NotNullWhen(true)]` attributes in helper - !fixup! Handle `IsNullOrEmpty(...)` metadata lack - !fixup! Use `ToString()` instead of suppression - Update `KnownHeaders` - then regenerate HttpHeaders.Generated.cs - Do generated JS files need to change? - !fixup! Allow `Charset` to be `null` - !fixup! Adjust to fix failing tests - note `HttpResponse.ContentType` type now matches `HttpRequest.ContentType` - !fixup! React to `HttpResponse.ContentType` change
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #43605
Annotated according to:
Microsoft.Extensions.FileProviders.Abstractions#57405Issue to fix implementation issues: #57518