Override memory-based ReadAsync & WriteAsync for SerialStream #56866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io |
|
Seems to also contribute to #54916 |
adamsitnik
reviewed
Aug 5, 2021
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs
Outdated
Show resolved
Hide resolved
| @@ -10,9 +10,6 @@ | |||
|
|
|||
| namespace System.IO.Ports | |||
| { | |||
| // Issue https://github.com/dotnet/runtime/issues/54916 | |||
There was a problem hiding this comment.
What about the Windows part? I know it's very archaic, but it seems that the implementation uses ReadFile and WriteFile methods, which means that we could just create a FileStream (with buffering disabled by passing bufferSize: 1) from the SafeFileHandle we get in
FileStream.
There was a problem hiding this comment.
I'll take a look, but it feels like a separate PR to me..
adamsitnik
approved these changes
Aug 9, 2021
This was referenced Aug 9, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #54575