Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory-based Read/WriteAsync overloads to SerialStream #54916

Closed
ViktorHofer opened this issue Jun 29, 2021 · 5 comments
Closed

Add memory-based Read/WriteAsync overloads to SerialStream #54916

ViktorHofer opened this issue Jun 29, 2021 · 5 comments
Assignees
Labels
area-System.IO help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 29, 2021

// 'SerialStream' overrides array-based 'ReadAsync' but does not override memory-based 'ReadAsync'. Consider overriding memory-based 'ReadAsync' to improve performance.
// 'SerialStream' overrides array-based 'WriteAsync' but does not override memory-based 'WriteAsync'. Consider overriding memory-based 'WriteAsync' to improve performance.

Disabling the warning in #54544. The overloads should be added to improve performance on .NETCoreApp.

cc @krwq @wfurt @stephentoub

@ghost
Copy link

ghost commented Jun 29, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

// 'SerialStream' overrides array-based 'ReadAsync' but does not override memory-based 'ReadAsync'. Consider overriding memory-based 'ReadAsync' to improve performance.
// 'SerialStream' overrides array-based 'WriteAsync' but does not override memory-based 'WriteAsync'. Consider overriding memory-based 'WriteAsync' to improve performance.

Disabling the warning in #54544. The overloads should be added to improve performance on .NETCoreApp.

cc @krwq @wfurt @stephentoub

Author: ViktorHofer
Assignees: -
Labels:

area-System.IO

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 29, 2021
@adamsitnik adamsitnik added help wanted [up-for-grabs] Good issue for external contributors and removed untriaged New issue has not been triaged by the area owner labels Jun 29, 2021
@adamsitnik adamsitnik modified the milestones: 6.0.0, Future Jun 29, 2021
@wcontayon
Copy link
Contributor

Hi @ViktorHofer it's an interesting issue. Can I try a PR ?

@ViktorHofer
Copy link
Member Author

Absolutely. I just assigned you to the issue. Go for it :)

@krwq
Copy link
Member

krwq commented Jul 8, 2021

@wcontayon thanks for offering help! Note you'll likely need to do a tiny refactor of code

@adamsitnik
Copy link
Member

fixed by #56866

@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

4 participants