-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory-based Read/WriteAsync overloads to SerialStream #54916
Comments
Tagging subscribers to this area: @dotnet/area-system-io Issue Details// 'SerialStream' overrides array-based 'ReadAsync' but does not override memory-based 'ReadAsync'. Consider overriding memory-based 'ReadAsync' to improve performance. Disabling the warning in #54544. The overloads should be added to improve performance on .NETCoreApp.
|
Hi @ViktorHofer it's an interesting issue. Can I try a PR ? |
Absolutely. I just assigned you to the issue. Go for it :) |
@wcontayon thanks for offering help! Note you'll likely need to do a tiny refactor of code |
fixed by #56866 |
// 'SerialStream' overrides array-based 'ReadAsync' but does not override memory-based 'ReadAsync'. Consider overriding memory-based 'ReadAsync' to improve performance.
// 'SerialStream' overrides array-based 'WriteAsync' but does not override memory-based 'WriteAsync'. Consider overriding memory-based 'WriteAsync' to improve performance.
Disabling the warning in #54544. The overloads should be added to improve performance on .NETCoreApp.
cc @krwq @wfurt @stephentoub
The text was updated successfully, but these errors were encountered: