Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1240010 #55743

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

dotnet-bot
Copy link
Collaborator

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ericstj
Copy link
Member

ericstj commented Jul 15, 2021

@maryamariyan the logging generator tests are failing because they are expecting non-localized messages:

    Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.MissingTemplate [FAIL]
      Assert.Contains() Failure
      Not found: Argument 'foo' is not referenced from the logging message
      In value:  No se hace referencia al argumento "foo" en el mensaje de registro
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs(164,0): at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.MissingTemplate()
        --- End of stack trace from previous location ---
    Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.MissingILogger [FAIL]
      Assert.Contains() Failure
      Not found: One of the arguments to the static logging method 'M1' must implement the Microsoft.Extensions.Logging.ILogger interface
      In value:  Uno de los argumentos para el metodo de registro estatico "M1" debe implementar la interfaz Microsoft.Extensions.Logging.ILogger
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs(503,0): at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.MissingILogger()
        --- End of stack trace from previous location ---
    Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.EventIdReuse [FAIL]
      Assert.Contains() Failure
      Not found: in class MyClass
      In value:  Varios metodos de registro usan el id. de evento 0 en la clase MyClass
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs(470,0): at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.EventIdReuse()
        --- End of stack trace from previous location ---
    Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.WithNullMessage_GeneratorWontFail [FAIL]
      Assert.Contains() Failure
      Not found: Argument 'foo' is not referenced from the logging message
      In value:  No se hace referencia al argumento "foo" en el mensaje de registro
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs(117,0): at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.WithNullMessage_GeneratorWontFail()
        --- End of stack trace from previous location ---
    Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.MissingArgument [FAIL]
      Assert.Contains() Failure
      Not found: Template 'foo' is not provided as argument to the logging method
      In value:  La plantilla "foo" no se proporciona como argumento para el metodo de registro
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs(180,0): at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorParserTests.MissingArgument()
        --- End of stack trace from previous location ---

@ericstj ericstj requested a review from maryamariyan July 15, 2021 17:39
Copy link
Member

@maryamariyan maryamariyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mainly reviewed the updated test file LoggerMessageGeneratorParserTests.cs and I believe the rest are boilerplate diff.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We accept that these translations are correct and the test issues should now be addressed.

@ghost
Copy link

ghost commented Jul 15, 2021

Hello @ericstj!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ericstj
Copy link
Member

ericstj commented Jul 15, 2021

Localized components test completed successfully. Remaining failures are flaky Linq.Expressions and Networking tests, and a nuget restore failure. Merging so that Preview7 gets localization.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants