Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1237880 #55654

Closed

Conversation

dotnet-bot
Copy link
Collaborator

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@stephentoub
Copy link
Member

@ericstj, what is the expected review required for these loc PRs?

@ghost
Copy link

ghost commented Jul 14, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: dotnet-bot
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ericstj
Copy link
Member

ericstj commented Jul 14, 2021

@stephentoub - we should classify as area-Infrastructure-Libraries and have folks review / signoff. Once the process is vetted it should be a simple merge like our codeflow PRs. This is the first one so it needs more scrutiny.

@jonfortescue I see this PR is removing translations. Is that expected?

@ericstj ericstj requested a review from jonfortescue July 14, 2021 17:06
@ericstj
Copy link
Member

ericstj commented Jul 14, 2021

Looks like all the translations being removed were previous community contributions to Microsoft.CSharp. Those resources don't actually ship but I think we should avoid losing the community contributions if possible. @jonfortescue any idea how to get the process to leave them be?

@jonfortescue
Copy link
Contributor

@ericstj this is definitely unusual and doesn't look like any of the instances I've seen of this before. Filed an issue with the loc team to see if we can figure this out here.

@ericstj
Copy link
Member

ericstj commented Jul 15, 2021

Closed in favor of #55743

@ericstj ericstj closed this Jul 15, 2021
@ericstj ericstj deleted the locfiles/da073f5c-8401-4f74-9443-c38eb1e7da0d branch July 15, 2021 17:32
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants