Use NuGet.config for restore during package testing

[ericstj]

Fixes #53810

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #53810

Author:	ericstj
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[ViktorHofer]

LGTM assuming that's the right location and the file will be considered during restore.

[ViktorHofer]

nit: why not replace the LocalPackagesPath property with RestoreAdditionalProjectSources?

[safern]

I think LocalPackagesPath is easier to remember when running package tests locally?

[ViktorHofer]

That property isn't supposed to be passed in by the user. It's already passed in and by default points to the artifacts packages dir:

runtime/src/libraries/pkg/test/testPackages.proj

Line 169 in 6058cb7

<TestRestoreCommand>$(TestRestoreCommand) /p:LocalPackagesPath=$(ArtifactsPackagesDir)</TestRestoreCommand>

[safern]

Good point. For some reason I thought it was for local testing, I forgot we generated the test restore command.

[ericstj]

Specifying known properties as global properties can make them effectively readonly in the evaluation, which could break other props/targets which were trying to append to them. This was the case with RestoreSources previously. I'm inclined to keep these seperate since it's not the intent of this to specify all additional restore sources, only one that we want to add.

[ViktorHofer]

Are you expecting this to be picked up by the test project as well or just by test.msbuild? The former would not see this file.

[ericstj]

There appears to be no directory in common with Helix payload structure and local structure. If this is changed to $(TestDir) it produces the correct layout locally but that's not present in helix :/. I guess we only need it to be present in Helix since that's the only place where it wouldn't find it in directory root. (since artifacts is below).

I'm debating just removing nuget.config entirely. We actually don't need to hit any feeds except nuget.org. The only place we need an additional feed is

runtime/src/libraries/pkg/test/packageSettings/System.IO.Ports/workaroundDowngrade.targets

Line 4 in 54fdd26

<PackageReference Include="runtime.native.System.IO.Ports" Version="$(runtimenativeSystemIOPortsVersion)" NoWarn="NU1605" />

but that could be done differently, using an offically released package.

Thoughts?

[ViktorHofer]

Why not just put the NuGet.config into a central location and point to it during the restore? There is a switch available for that. I'm changing the layout slightly with #53439 so I would recommend to wait for that to go in (which hopefully will in 1-2h).

[ericstj]

Any thoughts on this NuGet.config being more than we need for package restore in testing?

We actually don't need to hit any feeds except nuget.org

In fact, we probably don't want our packages depending on things from the internal feeds.

[ViktorHofer]

Any thoughts on this NuGet.config being more than we need for package restore in testing?

Nope I think that's fine. We follow the same approach in the installer tests in the runtime repo (they copy the NuGet.config over and add to it).

In fact, we probably don't want our packages depending on things from the internal feeds.

That's right, but we don't reference any internal feeds from our NuGet.config.

[ericstj]

Actually, if you remove Helix this PR is no longer needed, since NuGet.config will already be used. Closing this one.

[ViktorHofer]

@ericstj I folded your changes into #53905 as that simplifies where to put the NuGet.config (as we don't upload artifacts anymore).

[ViktorHofer]

Oh you were couple seconds faster than me commenting :D

[ericstj]

I had just reached your PR in my notifications inbox :)