Package testing shouldn't hard code restore sources

[ViktorHofer]

runtime/src/libraries/pkg/test/packageTest.targets

Lines 10 to 16 in 8709d59

	<RestoreSources>
	https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;
	https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json;
	https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;
	https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6-transport/nuget/v3/index.json;
	$(LocalPackagesPath)
	</RestoreSources>

The RestoreSources property is hardly used anymore as it doesn't support authentication and instead we specify the restore sources in the repo's NuGet.config file. We probably want to copy that file next to the test app so that the restore sources aren't duplicated.

cc @Anipik @ericstj @safern @joperezr

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

runtime/src/libraries/pkg/test/packageTest.targets

Lines 10 to 16 in 8709d59

	<RestoreSources>
	https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;
	https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json;
	https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;
	https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6-transport/nuget/v3/index.json;
	$(LocalPackagesPath)
	</RestoreSources>

The RestoreSources property is hardly used anymore as it doesn't support authentication and instead we specify the restore sources in the repo's NuGet.config file. We probably want to copy that file next to the test app so that the restore sources aren't duplicated.

cc @Anipik @ericstj @safern @joperezr

Author:	ViktorHofer
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[safern]

We probably want to copy that file next to the test app so that the restore sources aren't duplicated.

For the LocalPackagesPath would you have a placeholder and replace it before copying the file to the test app folder?

[ericstj]

Maybe we can just use RestoreAdditionalProjectSources for LocalPackagesPath

[safern]

I didn't know that property existed, good to know.

[ViktorHofer]

That was fixed via #53905