Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpStress: Disable firewall in Windows runs #52381

Merged
merged 2 commits into from
May 11, 2021

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented May 6, 2021

Fixes #50854. The issue seems to be caused by an unknown firewall problem, and from the POV of http stress testing it's a false negative. We need a quick solution to remove this failure type, because the high amount failures renders our stress test reports useless.

Since the build agents do not have a public IP, it seems OK to disable the Windows firewall for the runs.

/cc @MattGal @ViktorHofer

@ghost
Copy link

ghost commented May 6, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50854. The issue seems to be caused by an unknown firewall problem. Since the build agents do not have a public IP, it seems OK to disable the Windows firewall for the runs.

/cc @MattGal @ViktorHofer

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member Author

In the first run, failure happened in HTTP 2.0 (HTTP2 failure types known and documented in #42211):
https://dev.azure.com/dnceng/public/_build/results?buildId=1125329&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=abae1f68-3c73-5bff-491f-f2b908580ce6

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov requested a review from a team May 6, 2021 15:17
@GrabYourPitchforks
Copy link
Member

Disabling the firewall seems appropriate for this scenario. Is it possible to shrink the window any further than this PR proposes? For example, can the "disable firewall" rule be moved after the build but before the stress run? If the build also requires it for some reason, then no worries.

@wfurt
Copy link
Member

wfurt commented May 7, 2021

I think we need to do that only for the stress run itself as it interferes with the load. Everything else is working OK AFAIK.

@antonfirsov
Copy link
Member Author

@GrabYourPitchforks @wfurt limited the disable window to the HTTP 1.1 run, HTTP 2.0 is not impacted by #50854.

@antonfirsov

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@antonfirsov

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@GrabYourPitchforks
Copy link
Member

Thanks!

@antonfirsov antonfirsov merged commit d2c744f into main May 11, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@jkotas jkotas deleted the antonfirsov/httpstress-disable-firewall branch May 21, 2021 03:26
@ghost ghost locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpStress: connection failures with HTTP 1.1 caused by Windows Firewall
4 participants