-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpStress: Disable firewall in Windows runs #52381
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #50854. The issue seems to be caused by an unknown firewall problem. Since the build agents do not have a public IP, it seems OK to disable the Windows firewall for the runs. /cc @MattGal @ViktorHofer
|
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
In the first run, failure happened in HTTP 2.0 (HTTP2 failure types known and documented in #42211): |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
Disabling the firewall seems appropriate for this scenario. Is it possible to shrink the window any further than this PR proposes? For example, can the "disable firewall" rule be moved after the build but before the stress run? If the build also requires it for some reason, then no worries. |
I think we need to do that only for the stress run itself as it interferes with the load. Everything else is working OK AFAIK. |
@GrabYourPitchforks @wfurt limited the disable window to the HTTP 1.1 run, HTTP 2.0 is not impacted by #50854. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks! |
Fixes #50854. The issue seems to be caused by an unknown firewall problem, and from the POV of http stress testing it's a false negative. We need a quick solution to remove this failure type, because the high amount failures renders our stress test reports useless.
Since the build agents do not have a public IP, it seems OK to disable the Windows firewall for the runs.
/cc @MattGal @ViktorHofer