Skip to content

Commit

Permalink
HttpStress: Disable firewall in Windows runs (#52381)
Browse files Browse the repository at this point in the history
#50854 seems to be rooted in an unknown firewall problem, and from the POV of http stress testing it's a false negative. We need a quick solution to remove this failure type, because the high amount failures renders our stress test reports useless. Since the build agents do not have a public IP, it seems OK to disable the Windows firewall for the runs.
  • Loading branch information
antonfirsov authored May 11, 2021
1 parent be3f820 commit d2c744f
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion eng/pipelines/libraries/stress/http.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,22 @@ jobs:
displayName: Run HttpStress - HTTP 2.0
condition: and(eq(variables['buildRuntime.succeeded'], 'true'), eq(variables['buildStress.succeeded'], 'true'))
# Firewall is disabled for HTTP 1.1 runs.
# See: https://github.com/dotnet/runtime/issues/50854
- powershell: |
Set-NetFirewallProfile -Profile Domain, Public, Private -Enabled False
name: disableFirewall
displayName: Disable Firewall
- powershell: |
cd '$(httpStressProject)'
$env:HTTPSTRESS_CLIENT_ARGS = "$env:HTTPSTRESS_CLIENT_ARGS -http 1.1"
$env:HTTPSTRESS_SERVER_ARGS = "$env:HTTPSTRESS_SERVER_ARGS -http 1.1"
docker-compose up --abort-on-container-exit --no-color
displayName: Run HttpStress - HTTP 1.1
condition: and(eq(variables['buildRuntime.succeeded'], 'true'), eq(variables['buildStress.succeeded'], 'true'))
condition: and(eq(variables['buildRuntime.succeeded'], 'true'), eq(variables['buildStress.succeeded'], 'true'))
- powershell: |
Set-NetFirewallProfile -Profile Domain, Public, Private -Enabled True
name: enableFirewall
displayName: Enable Firewall

0 comments on commit d2c744f

Please sign in to comment.