-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/5.0] Fix logic to test bits in a constant vector (Vector256) #48613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 22, 2021
echesakov
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sandreenko
approved these changes
Feb 23, 2021
tannergooding
approved these changes
Feb 23, 2021
jeffschwMSFT
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. We should consider this for 5.0.x
leecow
added
Servicing-approved
Approved for servicing release
and removed
Servicing-consider
Issue for next servicing release review
labels
Mar 2, 2021
ghost
locked as resolved and limited conversation to collaborators
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-x64
arch-x86
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Servicing-approved
Approved for servicing release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #47385
Fix in master: #47385
Customer Impact
If a user tries to create a
Vector256
viaCreate
overload and the first half of its arguments are zeros and the second part is, let's say, all "1" (or any other constant) - a special optimization will always optimize thatCreate
toVector256<T>.Zero
. A simple example:prints:
but is expected to print:
Same for -1 and AllBitSets, and same for Vector64 on arm64.
Where
T
type is pretty much any type Vectors support.Testing
This PR adds a regression test.
Risk
Low. This impacts only rare specific cases with hardware intrinsics.
Regression
Yes, the optimization
Vector256(0,0,0...0) to Vector256<>.Zero
was introduced in 5.0