Add switches for more general altjit and cross-target commands #45605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib |
Add `-mch_arch` to specify which architecture to use when downloading MCH files from Azure Storage. The idea is that you can specify to download, say, arm64 MCH files and then run them on x64 by also specifying an arm64 cross-targeting JIT. Defaults to `-target_arch` (which itself defaults to the host architecture). Add `-jit` to allow specifying the JIT name to use. Do this instead of `-altjit`. Change `-altjit` to `--altjit`. It no longer takes a JIT name; use `-jit` instead for that purpose. Now, `--altjit` just sets the altjit variables. Add `-target_arch` and `-target_os` to specify the cross-target of the JIT. The `-target_arch`, in particular, is used to pass the `-target` argument to SuperPMI, which it needs to know which disassembler to use. So, for example, to run SuperPMI asm diffs with a Windows arm64 cross-JIT on Windows x64, you might use: ``` py superpmi.py asmdiffs -jit clrjit_win_arm64_x64.dll -target_arch arm64 ``` Unfortunately, these cross-JIT scenarios have other problems right now, but this scripting is a start.
BruceForstall
force-pushed
the
MoreGeneralSpmiTargeting
branch
from
ce7f0f2 to
f4bf624
Compare
|
ping. Can someone sign off? |
sandreenko
approved these changes
Dec 10, 2020
echesakov
approved these changes
Dec 10, 2020
I believe you need it if you are running against a non-native collection, e.g., running clrjit_win_arm_x86.dll (x86 hosted arm32-targeting cross-JIT) against an x86 collection MCH file. But I'm still not 100% clear on if even that needs the altjit variables set. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-mch_archto specify which architecture to use when downloadingMCH files from Azure Storage. The idea is that you can specify to
download, say, arm64 MCH files and then run them on x64 by also
specifying an arm64 cross-targeting JIT. Defaults to
-target_arch(which itself defaults to the host architecture).
Add
-jitto allow specifying the JIT name to use. Do this instead of-altjit.Change
-altjitto--altjit. It no longer takes a JIT name; use-jitinstead for that purpose. Now,
--altjitjust sets the altjitvariables.
Add
-target_archand-target_osto specify the cross-target of the JIT.The
-target_arch, in particular, is used to pass the-targetargumentto SuperPMI, which it needs to know which disassembler to use.
So, for example, to run SuperPMI asm diffs with a Windows arm64 cross-JIT
on Windows x64, you might use:
Unfortunately, these cross-JIT scenarios have other problems right now,
but this scripting is a start.