Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superpmi.py list-collections fail with 'CoreclrArguments' object has no attribute 'target_os' #45981

Closed
echesakov opened this issue Dec 11, 2020 · 0 comments · Fixed by #45983
Closed

superpmi.py list-collections fail with 'CoreclrArguments' object has no attribute 'target_os' #45981

echesakov opened this issue Dec 11, 2020 · 0 comments · Fixed by #45983
Assignees
@BruceForstall
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
6.0.0

Comments

@echesakov
Copy link
Contributor

Started failing after #45605

F:\echesako\git\runtime2>python src\coreclr\scripts\superpmi.py list-collections
Warning: deleting existing log file F:\echesako\git\runtime2\artifacts\spmi\superpmi.log
================ Logging to F:\echesako\git\runtime2\artifacts\spmi\superpmi.log
Using JIT/EE Version from jiteeversionguid.h: 790de1e5-1426-4ecf-939c-2cd60445c219
Traceback (most recent call last):
  File "F:\echesako\git\runtime2\src\coreclr\scripts\superpmi.py", line 3259, in <module>
    sys.exit(main(args))
  File "F:\echesako\git\runtime2\src\coreclr\scripts\superpmi.py", line 3242, in main
    list_collections_command(coreclr_args)
  File "F:\echesako\git\runtime2\src\coreclr\scripts\superpmi.py", line 2279, in list_collections_command
    blob_filter_string = "{}/{}/{}/".format(coreclr_args.jit_ee_version, coreclr_args.target_os, coreclr_args.mch_arch)
AttributeError: 'CoreclrArguments' object has no attribute 'target_os'

cc @BruceForstall
@echesakov echesakov added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 11, 2020
@echesakov echesakov added this to the 6.0.0 milestone Dec 11, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 11, 2020
@echesakov echesakov removed the untriaged New issue has not been triaged by the area owner label Dec 11, 2020
@BruceForstall BruceForstall self-assigned this Dec 11, 2020
BruceForstall added a commit to BruceForstall/runtime that referenced this issue Dec 11, 2020
@BruceForstall
Fix superpmi.py argument parsing
8e2dc38 
1. Hoist out argument parsing/verification of target_os/target_arch/mch_arch
so they apply to more commands that require them, e.g., "list-collections".
2. Rename `-jit` argument to `-jit_name` to be more explicit, and differentiate
it from the pre-existing `-jit_path` argument.
3. Hoist verification of `-jit_ee_version` to reduce code duplication.

Fixes dotnet#45981
@BruceForstall BruceForstall mentioned this issue Dec 11, 2020
Merged
BruceForstall added a commit that referenced this issue Dec 11, 2020
@BruceForstall
Fix superpmi.py argument parsing (#45983)
c943105 
1. Hoist out argument parsing/verification of target_os/target_arch/mch_arch
so they apply to more commands that require them, e.g., "list-collections".
2. Rename `-jit` argument to `-jit_name` to be more explicit, and differentiate
it from the pre-existing `-jit_path` argument.
3. Hoist verification of `-jit_ee_version` to reduce code duplication.

Fixes #45981
@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix superpmi.py argument parsing BruceForstall/runtime
3 participants
@echesakov @BruceForstall @Dotnet-GitSync-Bot