Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve symbols in dbgshim #44970

Merged
2 commits merged into from
Nov 20, 2020
Merged

Preserve symbols in dbgshim #44970

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a948e5
Preserve symbols in the dbgshim
hoyosjs Nov 19, 2020
0360f5d
Remove unused library group option.
hoyosjs Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/coreclr/src/dlls/dbgshim/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,15 @@ else(CLR_CMAKE_TARGET_WIN32)
# This option is necessary to ensure that the overloaded delete operator defined inside
# of the utilcode will be used instead of the standard library delete operator.
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Xlinker -Bsymbolic")

# The following linked options can be inserted into the linker libraries list to
# ensure proper resolving of circular references between a subset of the libraries.
set(START_LIBRARY_GROUP -Wl,--start-group)
hoyosjs marked this conversation as resolved.
Show resolved Hide resolved
set(END_LIBRARY_GROUP -Wl,--end-group)

# These options are used to force every object to be included even if it's unused.
set(START_WHOLE_ARCHIVE -Wl,--whole-archive)
set(END_WHOLE_ARCHIVE -Wl,--no-whole-archive)
endif(CLR_CMAKE_HOST_LINUX OR CLR_CMAKE_HOST_FREEBSD OR CLR_CMAKE_HOST_NETBSD OR CLR_CMAKE_HOST_SUNOS)

set_exports_linker_option(${EXPORTS_FILE})
Expand Down Expand Up @@ -69,9 +78,11 @@ if(CLR_CMAKE_HOST_WIN32)
)
else()
list(APPEND DBGSHIM_LIBRARIES
coreclrpal
mscorrc
${START_WHOLE_ARCHIVE}
coreclrpal
palrt
${END_WHOLE_ARCHIVE}
)
endif(CLR_CMAKE_HOST_WIN32)

Expand Down