Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve symbols in dbgshim #44970

Merged
2 commits merged into from
Nov 20, 2020
Merged

Preserve symbols in dbgshim #44970

2 commits merged into from
Nov 20, 2020

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Nov 19, 2020

No description provided.

@hoyosjs hoyosjs added this to the 6.0.0 milestone Nov 19, 2020
@hoyosjs hoyosjs requested a review from mikem8361 November 19, 2020 22:41
@hoyosjs hoyosjs self-assigned this Nov 19, 2020
@ghost
Copy link

ghost commented Nov 19, 2020

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: hoyosjs
Assignees: hoyosjs
Labels:

area-Diagnostics-coreclr, auto-merge

Milestone: 6.0.0

@ghost
Copy link

ghost commented Nov 19, 2020

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jkotas
Copy link
Member

jkotas commented Nov 19, 2020

Why do we need to do this?

@hoyosjs
Copy link
Member Author

hoyosjs commented Nov 19, 2020

The linker was somehow not preserving PAL_Random in dbgshim and it resulted in a failure to load it on Linux due to undefined symbol.

@ghost ghost merged commit d85f060 into dotnet:master Nov 20, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
@hoyosjs hoyosjs deleted the juhoyosa/dbgshim-pal branch September 19, 2022 21:17
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants