-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoreCLR runtime tests + Mono on the x64 iOS simulator #43954
CoreCLR runtime tests + Mono on the x64 iOS simulator #43954
Conversation
Tagging subscribers to this area: @directhex |
2687c27
to
b5c7d62
Compare
b5c7d62
to
96384fa
Compare
Current status: can build apps containing entire runtime test categories. Can also read stdout from instrumented native app launcher code from |
8356078
to
35e1759
Compare
35e1759
to
5701f04
Compare
Haven't spent much time on this this week; have mostly been occupied with arm64 simd. |
4fc4c19
to
fd4d9c3
Compare
36699c3
to
68709d8
Compare
I got the tests running in the simulator. I also tried getting these running on-device, but that will require a bit more work, and won't be a part of this PR. |
1579d96
to
9e52fcc
Compare
No progress made in last few days, will pick up this work next week. |
9e52fcc
to
7906f7c
Compare
@imhameed working on this item this week |
7906f7c
to
8cc0d0d
Compare
8cc0d0d
to
27e49da
Compare
baseservices_mono.app/runningmono.dll passed locally:
|
This reverts commit 2f0c8cab10e6157bf493a5e11ccb3ce2cdd12aa0.
b5d3a2e
to
f451eb0
Compare
@fanyang-mono @premun I'm going to merge this PR. I've disabled sending the tests to Helix, so this PR won't result in increased use of the OSX.1015.Amd64.Open pool. Followup work (like using CustomCommands, or completing the transition to |
…ger_proxy_attribute * origin/main: disable token info in traces. (dotnet#56780) [debugger] Fix debugger.break behavior (dotnet#56788) [mono][wasm] Allow setting env variables with '=' characters in the test runner. (dotnet#56802) Ecma edit for `conv.ovf.<to type>.un`. (dotnet#56450) Mark HandleProcessCorruptedStateExceptionsAttribute as obsolete (dotnet#56664) Enable SxS install of previews on Mac OS (dotnet#56797) CoreCLR runtime tests + Mono on the x64 iOS simulator (dotnet#43954) [main] Update dependencies from mono/linker (dotnet#56593) STJ: Fix deserialization of UInt16 properties (dotnet#56793)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removes stray debug logging and removes a redundant branch. See #43954 (comment) and #43954 (comment).
This creates another
runtime-staging
lane, named "Build iOSSimulator x64Release AllSubsets_Mono_RuntimeTests", that will eventually run the runtime
test suite against Mono's non-LLVM JIT on the iOS simulator on amd64 hosts.
Failing tests are added to the exclusion lists in issues.targets.
The tests aren't set to run yet, because they currently take a very long time
to execute.
AppleAppBuilder
no longer requires aMainLibraryFileName
. If omitted, onemust be supplied when the app bundle is launched via an environment variable
named
MONO_APPLE_APP_ENTRY_POINT_LIB_NAME
. The generated apps also acceptanother environment variable named
MONO_APPLE_APP_ASSEMBLY_LOAD_PREFIX
, whichis a hack used to allow assembly lookup to proceed in a nested app-relative
subdirectory before falling back to the root of the app bundle. This is
necessary because app bundles contain multiple individual test assemblies, and
these assemblies sometimes have dependencies with names that collide with the
dependencies of other test assemblies inside the bundle.