-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for issue mover bot #43279
Conversation
Tagging subscribers to this area: @maryamariyan |
Tagging subscribers to this area: @ViktorHofer |
Is the plan to have the move issues app installed for dotnet org? cc @terrajobst |
The bot is already installed |
What's the benefit of this bot over the GH feature? |
It can move issues to different organization |
How does the permission system work with that? Doesn't the bot need permissions in the different org? Is this about dotnet <--> mono? |
https://github.com/dessant/move-issues#usage
Yes but it can be used with others too |
Nice, we have the same issue with Nuget which has its own org. |
We use https://hubbup.io/ It would be good if would all use the same app for that. |
I agree that it would be good to standardize on a single app. Are there any signifiant advantages unique to either of these apps? If not, I would propose to revert this PR and use https://hubbup.io/ since it is run on more trustworthy account. |
Using |
hubbup.io is made by @Eilon, so he can comment on this. |
Yes I made and maintain hubbup.io. Having a bot is obviously nice because you can stay within GitHub. But with 3rd party bots you have to 100% trust the bot, the bot's code, the author of the code, the maintainer of the code, and the maintainers of every bit of source that went into the bot (e.g. other 3rd party libs). It's certainly not my call, but using 3rd party bots can carry much risk because at least usually they require a lot of permissions to do their work. I'm not sure what this bot needs but if it needs "a lot" of permissions then you need to be extra careful. |
Come on, this is open-sourced bot in 500 lines of JavaScript code and all permissions the bot need are just few
|
I think @Eilon's comment were generic. And yes, trusting apps is a big deal which is why we generally don't just allow anyone to install them and instead go through an approval step. Mover is approved in the dotnet org (not sure about the others) so you an use it already. Personally, I dislike that that repos must opt in by adding this file. I prefer Eilon's app because it works for all repos I have permissions to. |
@marek-safar indeed my comments were generic because I didn't know what permissions the bot requires. The bots often work by grabbing a token on your behalf and then doing arbitrary work with it, which you have to trust. There have been major incidents before where a "random" 3rd party component in the chain of dependencies was compromised and then everything downstream was compromised. Think of a scenario like NPM's left-pad and if it were compromised. Nearly every Node app in the world would potentially be compromised, including everyone using those apps. It's not a trivial matter of 500 lines of code, it's the 500,000 lines of code that are potentially used in the app. Either way, not my call here, just adding info. |
More details at https://github.com/dessant/move-issues