Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] [wasm][net] System.Net.Mail should not throw PNSE for full assembly. #43213

Merged
merged 16 commits into from
Oct 13, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 9, 2020

Backport of #42974 to release/5.0

It fixes customer reports of a regression from 3.2 where Browser lost support for mail operations as outlined in issue: #42576

/cc @kjpou1

Customer Impact

System.Net.Mail assembly is used by customers to verify mail addresses.
ContentDisposition is used and exposed in Http headers. Client relied on this functionality to be there for their existing code base to work after migration to 5.0.

SmtpClient is not supported via browser environment and is marked as PNSE.

Testing

Unit and Functional tests are included except for those concerning SmtpClient which is not delivered and marked as PNSE.

Risk

Would be calculation as low as it adds back support for functionality that was delivered before. SmtpClient is marked as PNSE and not delivered as it is not supported on browser environments and thus be calculated as zero functionality risk.

@ghost
Copy link

ghost commented Oct 9, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@Anipik Anipik added the Servicing-consider Issue for next servicing release review label Oct 9, 2020
@lewing lewing added the arch-wasm WebAssembly architecture label Oct 9, 2020
@leecow leecow added this to the 5.0.0 milestone Oct 13, 2020
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 13, 2020
@marek-safar marek-safar merged commit d90f149 into release/5.0 Oct 13, 2020
@marek-safar marek-safar deleted the backport/pr-42974-to-release/5.0 branch October 13, 2020 17:26
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants