-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][net] System.Net.Mail should not throw PNSE for full assembly. #42974
Conversation
Tagging subscribers to this area: @dotnet/ncl |
src/libraries/System.Net.Mail/src/System/Net/Mail/SmtpClient.Browser.cs
Outdated
Show resolved
Hide resolved
- SmtpClient relevant tests are not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you using as the bar to pull things back in?
Making sure the scenarios in the issue #42576 work and the tests pass. |
…operties - It does not hurt to have this.
src/libraries/System.Net.Mail/tests/Functional/MailMessageTest.cs
Outdated
Show resolved
Hide resolved
The only thing we removed was the SmtpClient and left all the remaining Functional and Unit tests case coverage. That should catch any fallout. |
src/libraries/System.Net.Mail/tests/Unit/SmtpConnectionTests/EhloParseExtensionsTest.cs
Show resolved
Hide resolved
I think we need to modify |
Removed in recent round of commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the comment
src/libraries/System.Net.Mail/tests/Unit/System.Net.Mail.Unit.Tests.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
src/libraries/System.Net.Mail/tests/Unit/System.Net.Mail.Unit.Tests.csproj
Outdated
Show resolved
Hide resolved
/backport to release/5.0 |
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/297521067 |
Add back certain functionality for System.Net.Mail.
Right now SmtpClient throws PNSE by providing a browser specific implementation.
Supported from the issue:
MailAddress passes:
Invalid email address parse:
MailMessage with ContentDisposition passes:
ContentDisposition constructor passes:
SmtpClient throws PNSE:
error:
CLI Tests ARE reactivated
Issue: #42576