[release/5.0-rc2] Fix cross-OS DAC metadata locator interface callback #41762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
sdmaclea
approved these changes
Sep 2, 2020
jeffschwMSFT
approved these changes
Sep 2, 2020
jamshedd
added
Servicing-approved
|
Approved for RC2. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41746 to release/5.0-rc2
This fixes the cross-OS DBI for debugging Linux on Windows. VS ran into this bug in their Linux coredump support. The metadata locator callback in DBI isn't be called (ifdef'ed out) so the debugger (VS) can't provide the missing metadata for the dump.
Issue: #41034
Customer Impact
Stack unwinding fails for Visual Studio customers loading Linux coredumps.
Testing
Tested with SOS's
clrstack -icommand which exercises this path.Risk
Risk is low and only for the Linux dump on Windows. It doesn't affect Windows dumps under VS or VSCode on Linux.