Fix cross-OS DAC metadata locator interface callback #41746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon |
|
@tommcdon do you think this should be ported to 5.0 rc2? |
Looks safe enough to port to 5.0 rc2. I'll probably port this to the 3.1-crossdac branch for 3.1.8 |
|
/backport to release/5.0-rc2 |
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/236756106 |
sdmaclea
added a commit
to sdmaclea/coreclr
that referenced
this pull request
Sep 25, 2020
sdmaclea
added a commit
to dotnet/coreclr
that referenced
this pull request
Sep 26, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the cross-OS DBI for debugging Linux on Windows. VS ran into this bug in their Linux coredump support. The metadata locator callback in DBI isn't be called (ifdef'ed out) so the debugger (VS) can't provide the missing metadata for the dump.
Issue: #41034