[RISC-V] JIT: Use ABI names for floating registers #109728

tomeksowi · 2024-11-12T11:42:40Z

ABI names are more readable on RISC-V and more consistent as we already use them for integer registers.

Contains almost no functional changes.

Part of #84834, cc @dotnet/samsung

dotnet-policy-service · 2024-11-12T11:43:16Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

tomeksowi · 2024-11-12T11:44:16Z

src/coreclr/jit/targetriscv64.h

+  #define FIRST_FLT_CALLEE_SAVED  REG_FS0
+  #define LAST_FLT_CALLEE_SAVED   REG_FS11
+  #define RBM_FLT_CALLEE_SAVED    (RBM_FS0|RBM_FS1|RBM_FS2|RBM_FS3|RBM_FS4|RBM_FS5|RBM_FS6|RBM_FS7|RBM_FS8|RBM_FS9|RBM_FS10|RBM_FS11)
+  #define RBM_FLT_CALLEE_TRASH    (RBM_FA0|RBM_FA1|RBM_FA2|RBM_FA3|RBM_FA4|RBM_FA5|RBM_FA6|RBM_FA7|RBM_FT0|RBM_FT1|RBM_FT2|RBM_FT3|RBM_FT4|RBM_FT5|RBM_FT6|RBM_FT7|RBM_FT8|RBM_FT9|RBM_FT10|RBM_FT11)


Contains almost no functional changes.

That should be the only one. Pretty sure temporary registers were missing from CALLEE_TRASH.

risc-vv · 2024-11-12T11:45:52Z

RISC-V Release-CLR-VF2: 9423 / 9444 (99.78%)

=======================
      passed: 9423
      failed: 4
     skipped: 107
      killed: 17
------------------------
  TOTAL libs: 9551
 TOTAL tests: 9551
   REAL time: 2h 54min 41s 885ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 523159 / 570874 (91.64%)

=======================
      passed: 523159
      failed: 881
     skipped: 1470
      killed: 46834
------------------------
  TOTAL libs: 257
 TOTAL tests: 572344
   REAL time: 2h 44min 57s 780ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 5a7c7ee16f5d8e90376f2f91d06d6e3b7150ab07
CI: 22c18a07455c9b7fa222cc5b1e07672ffa453212
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UsePublishedCrossgen2=false -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R /var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
unknown command
# TESTFX_RUN
unknown command

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9424 / 9445 (99.78%)

=======================
      passed: 9424
      failed: 4
     skipped: 107
      killed: 17
------------------------
  TOTAL libs: 9552
 TOTAL tests: 9552
   REAL time: 3h 2min 49s 984ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 523159 / 570874 (91.64%)

=======================
      passed: 523159
      failed: 881
     skipped: 1470
      killed: 46834
------------------------
  TOTAL libs: 257
 TOTAL tests: 572344
   REAL time: 2h 44min 57s 780ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 5a7c7ee16f5d8e90376f2f91d06d6e3b7150ab07
CI: 22c18a07455c9b7fa222cc5b1e07672ffa453212
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UsePublishedCrossgen2=false -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R /var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
unknown command
# TESTFX_RUN
unknown command

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-QEMU: 9424 / 9445 (99.78%)

=======================
      passed: 9424
      failed: 4
     skipped: 107
      killed: 17
------------------------
  TOTAL libs: 9552
 TOTAL tests: 9552
   REAL time: 57min 56s 240ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 557755 / 603157 (92.47%)

=======================
      passed: 557755
      failed: 1086
     skipped: 1394
      killed: 44316
------------------------
  TOTAL libs: 257
 TOTAL tests: 604551
   REAL time: 2h 21min 50s 198ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 5a7c7ee16f5d8e90376f2f91d06d6e3b7150ab07
CI: 22c18a07455c9b7fa222cc5b1e07672ffa453212
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UsePublishedCrossgen2=false -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R /godata/pipelines/Release-CLR-QEMU/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
unknown command
# TESTFX_RUN
unknown command

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

tomeksowi · 2024-11-18T16:38:35Z

@dotnet/jit-contrib PTAL

tomeksowi · 2024-11-25T15:55:02Z

@LuckyXu-HF @shushanhf IIRC LoongArch has similar naming

Use ABI names for floating registers

5a7c7ee

dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 12, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 12, 2024

tomeksowi commented Nov 12, 2024

View reviewed changes

clamp03 assigned tomeksowi Nov 12, 2024

clamp03 added the arch-riscv Related to the RISC-V architecture label Nov 12, 2024

am11 referenced this pull request in am11/runtime Nov 13, 2024

Fix registers/offsets in riscv-nativeaot.

8adbc73

clamp03 approved these changes Nov 19, 2024

View reviewed changes

clamp03 requested review from jkotas and jakobbotsch November 19, 2024 02:48

jakobbotsch approved these changes Nov 25, 2024

View reviewed changes

jakobbotsch merged commit d5b6aec into dotnet:main Nov 25, 2024
106 of 108 checks passed

mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024

Use ABI names for floating registers (dotnet#109728)

be0d794

github-actions bot locked and limited conversation to collaborators Dec 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RISC-V] JIT: Use ABI names for floating registers #109728

[RISC-V] JIT: Use ABI names for floating registers #109728

tomeksowi commented Nov 12, 2024

dotnet-policy-service bot commented Nov 12, 2024

tomeksowi Nov 12, 2024 •

edited

Loading

risc-vv commented Nov 12, 2024 •

edited

Loading

tomeksowi commented Nov 18, 2024

tomeksowi commented Nov 25, 2024

[RISC-V] JIT: Use ABI names for floating registers #109728

[RISC-V] JIT: Use ABI names for floating registers #109728

Conversation

tomeksowi commented Nov 12, 2024

dotnet-policy-service bot commented Nov 12, 2024

tomeksowi Nov 12, 2024 • edited Loading

Choose a reason for hiding this comment

risc-vv commented Nov 12, 2024 • edited Loading

tomeksowi commented Nov 18, 2024

tomeksowi commented Nov 25, 2024

tomeksowi Nov 12, 2024 •

edited

Loading

risc-vv commented Nov 12, 2024 •

edited

Loading