Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable build with Checked option for libraries configuration #108433

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Param(
[switch]$cross = $false,
[string][Alias('s')]$subset,
[ValidateSet("Debug","Release","Checked")][string][Alias('rc')]$runtimeConfiguration,
[ValidateSet("Debug","Release")][string][Alias('lc')]$librariesConfiguration,
[ValidateSet("Debug","Release","Checked")][string][Alias('lc')]$librariesConfiguration,
[ValidateSet("CoreCLR","Mono")][string][Alias('rf')]$runtimeFlavor,
[ValidateSet("Debug","Release","Checked")][string][Alias('hc')]$hostConfiguration,
[switch]$usemonoruntime = $false,
Expand All @@ -41,7 +41,7 @@ function Get-Help() {
Write-Host " -help (-h) Print help and exit."
Write-Host " -hostConfiguration (-hc) Host build configuration: Debug, Release or Checked."
Write-Host " [Default: Debug]"
Write-Host " -librariesConfiguration (-lc) Libraries build configuration: Debug or Release."
Write-Host " -librariesConfiguration (-lc) Libraries build configuration: Debug, Release or Checked."
Write-Host " [Default: Debug]"
Write-Host " -os Target operating system: windows, linux, osx, android, wasi or browser."
Write-Host " [Default: Your machine's OS.]"
Expand Down
4 changes: 2 additions & 2 deletions eng/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -384,12 +384,12 @@ while [[ $# > 0 ]]; do
fi
passedLibConf="$(echo "$2" | tr "[:upper:]" "[:lower:]")"
case "$passedLibConf" in
debug|release)
debug|release|checked)
val="$(tr '[:lower:]' '[:upper:]' <<< ${passedLibConf:0:1})${passedLibConf:1}"
;;
*)
echo "Unsupported libraries configuration '$2'."
echo "The allowed values are Debug and Release."
echo "The allowed values are Debug, Release and Checked."
exit 1
;;
esac
Expand Down