Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable build with Checked option for libraries configuration #108433

Closed

Conversation

bartlomiejko
Copy link

Enabling build with Checked configuration for -lc / -librariesConfiguration switch as currently this option is blocked from build command. Such build can be done with /p:LibrariesConfiguration=Checked msbuild option and is working fine in case of FX tests for risc-v.
Part of #84834
cc @dotnet/samsung

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 1, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@bartlomiejko
Copy link
Author

@dotnet-policy-service agree company="Samsung"

@ViktorHofer
Copy link
Member

The Checked configuration value only applies to the clr and mono runtimes but not to the libraries.

@clamp03
Copy link
Member

clamp03 commented Oct 10, 2024

@bartlomiejko I close this PR because there is no action over a week and you don't work RISC-V project anymore. If I am wrong, please leave any comment and open this PR. Thank you.

@clamp03 clamp03 closed this Oct 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants