Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature switch doc for WinForms feature switches #104673

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

LakshanF
Copy link
Contributor

Document the WinForms feature switches covered in dotnet/winforms#11568 and dotnet/sdk#41702

@LakshanF LakshanF added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jul 10, 2024
@LakshanF LakshanF requested a review from sbomer July 10, 2024 12:53
@LakshanF LakshanF self-assigned this Jul 10, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member

Is this the right place to document these? We don't document e.g. ASP.NET feature switches here. The code doesn't live here and this is not a docs repo. Cc @eerhardt

@stephentoub stephentoub merged commit cc96c13 into dotnet:main Jul 22, 2024
12 checks passed
| EnableCppCLIHostActivation | System.Runtime.InteropServices.EnableCppCLIHostActivation | C++/CLI host activation code is disabled when set to false and related functionality can be trimmed. |
| MetadataUpdaterSupport | System.Reflection.Metadata.MetadataUpdater.IsSupported | Metadata update related code to be trimmed when set to false |
| _EnableConsumingManagedCodeFromNativeHosting | System.Runtime.InteropServices.EnableConsumingManagedCodeFromNativeHosting | Getting a managed function from native hosting is disabled when set to false and related functionality can be trimmed. |
| VerifyDependencyInjectionOpenGenericServiceTrimmability | Microsoft.Extensions.DependencyInjection.VerifyOpenGenericServiceTrimmability | When set to true, DependencyInjection will verify trimming annotations applied to open generic services are correct |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VerifyDependencyInjectionOpenGenericServiceTrimmability and number of other feature switches deleted here are not documented in https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options#trimming-framework-library-features . @LakshanF Should their documentation stay here or do you plan to add their documentation in the docs repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per dotnet/docs#41739 (comment) I don't think we want that one documented on learn.microsoft.com.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants