Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include WinForms trimming feature switch information #102619

Closed
LakshanF opened this issue May 23, 2024 · 3 comments
Closed

Include WinForms trimming feature switch information #102619

LakshanF opened this issue May 23, 2024 · 3 comments
Assignees
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Milestone

Comments

@LakshanF
Copy link
Contributor

LakshanF commented May 23, 2024

The feature switches related to WinForms trimming that are not yet defined in runtime trimming should be updated on a relevant WinForms target file or at Microsoft.NET.ILLink.targets and documented.

@LakshanF LakshanF added the area-Tools-ILLink .NET linker development as well as trimming analyzers label May 23, 2024
@LakshanF LakshanF self-assigned this May 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 23, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member

These would ideally be in WinForms-specific .targets. The feature switches we keep in the ILLink targets are specific to dotnet/runtime repo. We don't e.g. define feature switches for ASP.NET in this file. (Might want to move the issue to WinForms.)

@agocke agocke added this to the Future milestone Jul 8, 2024
@agocke agocke removed the untriaged New issue has not been triaged by the area owner label Jul 8, 2024
@LakshanF
Copy link
Contributor Author

LakshanF commented Jul 10, 2024

This work is done via dotnet/winforms#11568 for the default values when trimming, and dotnet/sdk#41702 for the RuntimeHostConfiguration propagation.

Documenting is via #104673

@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
Archived in project
Development

No branches or pull requests

3 participants