Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Test failing on nodejs - SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.ResponseHeaders_ExtraWhitespace_Trimmed #77631

Closed
radical opened this issue Oct 29, 2022 · 3 comments · Fixed by #78375
Closed

[wasm] Test failing on nodejs - SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.ResponseHeaders_ExtraWhitespace_Trimmed #77631

radical opened this issue Oct 29, 2022 · 3 comments · Fixed by #78375
Assignees
@maraf
Labels
arch-wasm WebAssembly architecture area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-failure
Milestone
8.0.0

Comments

@radical
Copy link
Member

radical commented Oct 29, 2022 •
edited by build-analysis bot
Loading

log:

[09:31:18] info: Starting:    System.Net.Http.Functional.Tests.dll
[09:31:19] info: (node:13868) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
[09:31:19] info: (Use `node --trace-warnings ...` to show where the warning was created)
[09:31:19] fail: [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.ResponseHeaders_ExtraWhitespace_Trimmed
[09:31:19] info: Assert.True() Failure
[09:31:19] info: Expected: True
[09:31:19] info: Actual:   False
[09:31:19] info:    at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.<ResponseHeaders_ExtraWhitespace_Trimmed>b__1_0(Uri uri)
[09:31:19] info:    at System.Threading.Tasks.TaskTimeoutExtensions.GetRealException(Task task)
[09:31:19] info: --- End of stack trace from previous location ---
[09:31:19] info:    at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
[09:31:19] info:    at System.Net.Test.Common.LoopbackServer.<>c__DisplayClass15_0.<<CreateClientAndServerAsync>b__0>d.MoveNext()
[09:31:19] info: --- End of stack trace from previous location ---
[09:31:19] info:    at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options)
[09:31:19] info:    at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.ResponseHeaders_ExtraWhitespace_Trimmed()
[09:31:19] info: --- End of stack trace from previous location ---

This started in the same time range as #77630 .

cc @pavelsavara @maraf

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@radical radical added arch-wasm WebAssembly architecture area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-failure labels Oct 29, 2022
@radical radical added this to the 8.0.0 milestone Oct 29, 2022
@ghost
Copy link

ghost commented Oct 29, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

log:

[09:31:18] info: Starting:    System.Net.Http.Functional.Tests.dll
[09:31:19] info: (node:13868) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
[09:31:19] info: (Use `node --trace-warnings ...` to show where the warning was created)
[09:31:19] fail: [FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.ResponseHeaders_ExtraWhitespace_Trimmed
[09:31:19] info: Assert.True() Failure
[09:31:19] info: Expected: True
[09:31:19] info: Actual:   False
[09:31:19] info:    at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.<ResponseHeaders_ExtraWhitespace_Trimmed>b__1_0(Uri uri)
[09:31:19] info:    at System.Threading.Tasks.TaskTimeoutExtensions.GetRealException(Task task)
[09:31:19] info: --- End of stack trace from previous location ---
[09:31:19] info:    at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
[09:31:19] info:    at System.Net.Test.Common.LoopbackServer.<>c__DisplayClass15_0.<<CreateClientAndServerAsync>b__0>d.MoveNext()
[09:31:19] info: --- End of stack trace from previous location ---
[09:31:19] info:    at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options)
[09:31:19] info:    at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.ResponseHeaders_ExtraWhitespace_Trimmed()
[09:31:19] info: --- End of stack trace from previous location ---

This started in the same time range as #77630 .

cc @pavelsavara @maraf

Author: radical
Assignees: -
Labels:

arch-wasm, area-System.Net.Http, blocking-clean-ci, test-failure
Milestone: 8.0.0

@radical radical mentioned this issue Oct 30, 2022
Merged
@runfoapp runfoapp bot mentioned this issue Oct 31, 2022
Closed
@radical radical mentioned this issue Nov 1, 2022
Merged
@radical
Copy link
Member Author

radical commented Nov 4, 2022

These are failing to find the test headers in the http response. And also the app might be crashing at the end. And trivially reproducible.

@naricc naricc mentioned this issue Nov 11, 2022
Merged
@radical
Copy link
Member Author

radical commented Nov 15, 2022

@maraf this is still failing, keeping runtime-wasm red. Can we disable the tests?

@maraf maraf mentioned this issue Nov 15, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 15, 2022
radical pushed a commit that referenced this issue Nov 15, 2022
@maraf
[wasm] Test `SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Htt…
e2ef255 
…p11.ResponseHeaders_ExtraWhitespace_Trimmed` not supported on NodeJS. (#78375)

Test `SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http11.ResponseHeaders_ExtraWhitespace_Trimmed` is not supported on NodeJS.
Test introduced in the #74393.
Closes #77631.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-failure
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] Test for header trimming not supported on NodeJS maraf/runtime
2 participants
@radical @maraf