Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] browser-eventpipe sample broken with PerfTracing build - JSExportAttribute' is only supported on: 'browser' #77630

Closed
1 task
radical opened this issue Oct 29, 2022 · 4 comments
Closed
1 task

[wasm] browser-eventpipe sample broken with PerfTracing build - JSExportAttribute' is only supported on: 'browser' #77630

radical opened this issue Oct 29, 2022 · 4 comments
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-Diagnostics-mono blocking-clean-ci-optional Blocking optional rolling runs
Milestone
8.0.0

Comments

@radical
Copy link
Member

radical commented Oct 29, 2022

This is reproducible on main. PerfTracing build on runtime-wasm:

/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Program.cs(136,10): error CA1416: This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'. [/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj]
##[error]src/mono/sample/wasm/browser-eventpipe/Program.cs(136,10): error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'.
/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Program.cs(142,10): error CA1416: This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'. [/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj]
##[error]src/mono/sample/wasm/browser-eventpipe/Program.cs(142,10): error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'.
/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Program.cs(106,10): error CA1416: This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'. [/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj]
##[error]src/mono/sample/wasm/browser-eventpipe/Program.cs(106,10): error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'.

cc @lambdageek @pavelsavara

TODO:

  • We should build the threading, and perftracing related samples on runtime pipeline too
@radical radical added arch-wasm WebAssembly architecture blocking-clean-ci-optional Blocking optional rolling runs labels Oct 29, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 29, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Oct 29, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This is reproducible on main. PerfTracing build on runtime-wasm:

/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Program.cs(136,10): error CA1416: This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'. [/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj]
##[error]src/mono/sample/wasm/browser-eventpipe/Program.cs(136,10): error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'.
/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Program.cs(142,10): error CA1416: This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'. [/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj]
##[error]src/mono/sample/wasm/browser-eventpipe/Program.cs(142,10): error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'.
/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Program.cs(106,10): error CA1416: This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'. [/__w/1/s/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj]
##[error]src/mono/sample/wasm/browser-eventpipe/Program.cs(106,10): error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'JSExportAttribute' is only supported on: 'browser'.

cc @lambdageek @pavelsavara

TODO:

  • We should build the threading, and perftracing related samples on runtime pipeline too
Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci-optional
Milestone: -

@radical radical added this to the 8.0.0 milestone Oct 29, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Oct 29, 2022
@radical radical mentioned this issue Oct 29, 2022
Closed
@radical radical changed the title [wasm] browser-eventpipe sample broke with PerfTracing build - JSExportAttribute' is only supported on: 'browser' [wasm] browser-eventpipe sample broken with PerfTracing build - JSExportAttribute' is only supported on: 'browser' Oct 29, 2022
@naricc naricc mentioned this issue Oct 29, 2022
Merged
@radical radical mentioned this issue Oct 30, 2022
Merged
@pavelsavara pavelsavara self-assigned this Oct 31, 2022
@runfoapp runfoapp bot mentioned this issue Oct 31, 2022
Closed
@pavelsavara
Copy link
Member

<RunAnalyzers>true</RunAnalyzers> makes the difference

@pavelsavara pavelsavara mentioned this issue Nov 1, 2022
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 1, 2022
@pavelsavara pavelsavara mentioned this issue Nov 1, 2022
Merged
@radical
Copy link
Member Author

radical commented Nov 1, 2022

Fixed by #77704 .

@radical radical closed this as completed Nov 1, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Diagnostics-mono blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] workaround EP sample compilation pavelsavara/runtime
3 participants
@radical @pavelsavara @jeffschwMSFT