Fix UnscopedRef handling in indexers #74343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
Waiting for #74341 to merge before publishing |
jaredpar
force-pushed
the
ref-more2-fix
branch
4 times, most recently
from
e9c8a8b to
08617ab
Compare
The object initializer logic wasn't completely handling the lifetime of the `in` part of parameters. It was considering it escaping even if it wasn't marked as `[UnscopedRef]` closes dotnet#66056
|
@cston, @jjonescz, @RikkiGibson PTAL |
cston
reviewed
Jul 15, 2024
| local = new() { [in x] = "" }; // 1 | ||
| local = new() { [in y] = "" }; // 2 | ||
| local = new() { [0] = "" }; // 3 | ||
| } |
cston
reviewed
Jul 15, 2024
| static S1 Test1(int x) => new S1() { [in x] = "" }; // 1 | ||
| static S1 Test2(in int x) => new S1() { [in x] = "" }; | ||
| static S1 Test3(scoped in int x) => new S1() { [in x] = "" }; // 2 | ||
| static S1 Test3(int[] x) => new S1() { [in x[0]] = "" }; // 2 |
cston
approved these changes
Jul 15, 2024
RikkiGibson
reviewed
Jul 15, 2024
| Span<int> heapSpan = default; | ||
|
|
||
| var local1 = new S1(ref heapSpan) { [heapSpan] = 0 }; | ||
| var local2 = new S1(ref heapSpan) { [stackSpan] = 0 }; // 1 |
There was a problem hiding this comment.
Is behavior of this test affected by the impl change in this PR?
There was a problem hiding this comment.
No. I was stacking PRs waiting for my original indexer PR to get final sign off. This test was meant to be a part of that PR but ended up in the sub-branch for this change.
Co-authored-by: Rikki Gibson <[email protected]>
|
@RikkiGibson feedback addressed |
RikkiGibson
approved these changes
Jul 23, 2024
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object initializer logic wasn't completely handling the lifetime of
the
inpart of parameters. It was considering it escaping even if itwasn't marked as
[UnscopedRef]closes #66056