-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests to verify ref safety bug fix #74341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Jul 10, 2024
Waiting for #73842 to merge before publishing |
These tests verify that issue dotnet#63852 is fixed. It was very likely fixed as part of dotnet#73081 closes dotnet#63852
@cston, @jjonescz, @RikkiGibson PTAL test change to verify bug fix |
jjonescz
approved these changes
Jul 15, 2024
jaredpar
force-pushed
the
ref-more-fix
branch
2 times, most recently
from
July 15, 2024 13:41
33411cd
to
77b5387
Compare
jjonescz
reviewed
Jul 15, 2024
src/Compilers/CSharp/Test/Semantic/Semantics/RefEscapingTests.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Jul 15, 2024
[InlineData(LanguageVersion.CSharp10)] | ||
[InlineData(LanguageVersion.CSharp11)] | ||
[WorkItem("https://github.com/dotnet/roslyn/issues/63852")] | ||
public void UserDefinedBinaryOperator_RefStruct_Compound_RegressionTest1(LanguageVersion languageVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cston
approved these changes
Jul 15, 2024
Co-authored-by: Jan Jones <[email protected]>
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests verify that issue #63852 is fixed. It was very likely fixed
as part of #73081
closes #63852