fixing error formatting for generic attribute missing errors #69735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
ghost
added
the
Community
|
@dotnet-policy-bot agree |
jcouv
reviewed
Aug 28, 2023
jcouv
reviewed
Aug 28, 2023
jcouv
reviewed
Aug 28, 2023
|
Thanks for looking at this recently opened issue so quickly :-) |
jcouv
reviewed
Aug 28, 2023
@jcouv thanks for the quick review, I definitely agree with all of it. Sorry it took a bit; I was at work! |
jcouv
reviewed
Aug 29, 2023
jcouv
reviewed
Aug 29, 2023
jcouv
reviewed
Aug 29, 2023
|
@dotnet/roslyn-compiler for another review. Thanks |
333fred
approved these changes
Aug 29, 2023
|
Thanks @kinkeadian25! |
Thank you for posting the issue @333fred!! Cool to get a compiler issue done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, added a check on arity in the construction of the message.
Hopefully as I get more and more comfortable, I can have everything necessary added each PR. Stoked to be back working on Roslyn! Please let me know any changes I need to make to this.
Closes #69700